buster/packages/ai/tests/tools/integration/create-metrics-file-tool.in...

386 lines
11 KiB
TypeScript
Raw Normal View History

Mastra braintrust (#391) * type fixes * biome clean on ai * add user to flag chat * attempt to get vercel deployed * Update tsup.config.ts * Update pnpm-lock.yaml * Add @buster/server2 Hono API app with Vercel deployment configuration * slack oauth integration * mainly some clean up and biome formatting * slack oauth * slack migration + snapshot * remove unused files * finalized docker image for porter * Create porter_app_buster-server_3155.yml file * Add integration tests for Slack handler and refactor Slack OAuth service - Introduced integration tests for the Slack handler, covering OAuth initiation, callback handling, and integration status retrieval. - Refactored Slack OAuth service to improve error handling and ensure proper integration state management. - Updated token storage implementation to use a database vault instead of Supabase. - Enhanced existing tests for better coverage and reliability, including cleanup of test data. - Added new utility functions for managing vault secrets in the database. * docker image update * new prompts * individual tests and a schema fix * server build * final working dockerfile * Update Dockerfile * new messages to slack messages (#369) * Update dockerfile * Update validate-env.js * update build pipeline * Update the dockerfile flow * finalize logging for pino * stable base * Update cors middleware logger * Update cors.ts * update docker to be more imformative * Update index.ts * Update auth.ts * Update cors.ts * Update cors.ts * Update logger.ts * remove logs * more cors updates * build server shared * Refactor PostgreSQL credentials handling and remove unused memory storage. Update package dependencies. (#370) * tons of file parsing errors (#371) * Refactor PostgreSQL credentials handling and remove unused memory storage. Update package dependencies. * tons of file parsing errors * Dev mode updates * more stable electric handler * Dal/agent-self-healing-fixes (#372) * change to 6 min * optmizations around saving and non-blocking actions. * stream optimizations * Dal/agent-self-healing-fixes (#373) * change to 6 min * optmizations around saving and non-blocking actions. * stream optimizations * change porter staging deploy to mastra-braintrust. * new path for porter deploy * deploy to staging fix * Create porter_app_mastra-braintrust-api_3155.yml file (#375) Co-authored-by: porter-deployment-app[bot] <87230664+porter-deployment-app[bot]@users.noreply.github.com> * Update sizing and opacity * supe up the instance for mastra * environment staging * ssl script * copy path * Update list padding * no throttle and the anthropic cached * move select to the top * Update margin inline start * shrink reasoning vertical space to 2px * semi bold font for headers * update animation timing * haiku * Add createTodoList tool and integrate into create-todos-step * chat helper on post chat * only trigger cicd when change made * Start created streaming text components * Refactor analyst agent task to initialize Braintrust logging asynchronously and parallelize database queries for improved performance. Adjusted cleanup timeout for Braintrust traces to reduce delays. * fixed reasoned for X, so that it rounds down to the minute * Update users page * update build pipeline for new web * document title update * Named chats for page * Datasets titles * Refactor visualization tools and enhance error handling in retryable agent stream. Removed unused metricValueLabel from metrics file tool, updated metric configuration schemas, and improved healing mechanism for tool errors during streaming. * analyst * document title updates * Update useDocumentTitle.tsx * Refactor tool choice configuration in create-todos-step to use structured object. Remove exponential backoff logic from retryable agent stream for healable errors. Introduce new test for real-world healing scenarios in retryable agent stream. * Refactor SQL validation logic in modify-metrics-file-tool to skip unnecessary checks when SQL has not changed. Enhance error handling and update validation messages. Clean up code formatting for improved readability. * update collapse for filecard * chevron collapse * Jacob prompt changes (#376) * prompt changes to improve filtering logic and handle priv/sec errors * prompt changes to make aggregation better and improved filter best practices * Update packages/ai/src/steps/create-todos-step.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update packages/ai/src/agents/think-and-prep-agent/think-and-prep-instructions.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update packages/ai/src/steps/create-todos-step.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Jacob Anderson <jacobanderson@Jacobs-MacBook-Air.local> Co-authored-by: dal <dallin@buster.so> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * think and prep * change header and strong fonts weights * Update get collection * combo chart x axis update * Create a chart schemas as types * schema types * simple unit tests for line chart props * fix the response file ordering iwth active selection. * copy around reasoning messages taken care of * fix nullable user message and file processing and such. * update ticks for chart config * fix todo parsing. * app markdown update * Update splitter to use border instead of width * change ml * If no file is found we should auto redirect * Refactor database connection handling to support SSL modes. Introduced functions to extract SSL parameters and manage connections based on SSL requirements, including a custom verifier for unverified connections. * black box message update * chat title updates * optimizations for trigger. * some keepalive logic on the anthropic cached * keep title empty until new one * no duplicate messages * null user message on asset pull * posthog error handling * 20 sec idle timeout on anthropic * null req message * fixed modificiation names missing * Refactor tool call handling to support new content array format in asset messages and context loaders * cache most recent file from workflow * Enhance date and number detection in createDataMetadata function to improve data type handling for metrics files * group hover effect for message * logging for chat * Add messageId handling and file association tracking in dashboard and metrics tools - Updated runtime context to include messageId in create and modify dashboard and metrics file tools. - Implemented file association tracking based on messageId in create and modify functions for both dashboards and metrics. - Ensured type consistency by using AnalystRuntimeContext in runtime context parameters. * logging for chat * message type update * Route to first file instead * trigger moved to catalog * Enhance file selection logic to support YAML parsing and improve logging - Updated `extractMetricIdsFromDashboard` to first attempt JSON parsing, falling back to a regex-based YAML parsing for metric IDs. - Added detailed debug logging in `selectFilesForResponse` to track file selection process, including metrics and dashboards involved. - Introduced tests for various scenarios in `file-selection.test.ts` to ensure correct behavior with dashboard context and edge cases. * trigger dev v4-beta * Retry + Self Healing (#381) * Refactor retry logic in analyst and think-and-prep steps Co-authored-by: dallin <dallin@buster.so> * some fixes * console log error * self healing * todos retry --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * remove lots of logs * Remove chat streaming * Remove chat streaming * timeout * Change to updated at field * link to home * Update timeout settings for HTTP and HTTPS agents from 20 seconds to 10 seconds for improved responsiveness. * Add utils module and integrate message conversion in post_chat_handler * Implement error handling for extract values (#382) * Remove chat streaming * Improve error handling and logging in extract values and chat title steps Co-authored-by: dallin <dallin@buster.so> --------- Co-authored-by: Nate Kelley <nate@buster.so> Co-authored-by: Cursor Agent <cursoragent@cursor.com> * loading icon for buster avatar * finalize tooltip cache * upgrade mastra * increase retries * Add redo functionality for chat messages - Introduced `redoFromMessageId` parameter in `handleExistingChat` to allow users to specify a message to redo from. - Implemented validation to ensure the specified message belongs to the current chat. - Added `softDeleteMessagesFromPoint` function to soft delete a message and all subsequent messages in the same chat, facilitating the redo feature. * fix electric potential memory leak * tooltip cache and chart cleanup * Update bullet to be more indented * latest version number * add support endpoint to new server * Fix jank in combo bar charts * index check for dashboard * Collapse only if there are metrics * Is finished reasoing back * Update dependencies and enhance chat message handling - Upgraded `@mastra/core` to version 0.10.8 and added `node-sql-parser` at version 5.3.10 in the lock file. - Improved integration tests for chat message redo functionality, ensuring correct behavior when deriving `chat_id` from `message_id`. - Enhanced error handling and validation in the `initializeChat` function to manage cases where `chat_id` is not provided. * Update pnpm-lock and enhance chat message integration tests - Added `node-sql-parser` version 5.3.10 to dependencies and updated the lock file. - Improved integration tests for chat message redo functionality, ensuring accurate deletion and retrieval of messages. - Enhanced the `initializeChat` function to derive `chat_id` from `message_id` when not provided, improving error handling and validation. * remove .env import breaking build * add updated at to the get chat handler * zmall runtime error fix * permission tests passing * return updated at on the get chat handler now * slq parser fixes * Implement chat access control logic and add comprehensive tests - Developed the `canUserAccessChat` function to determine user access to chats based on direct permissions, collection permissions, creator status, and organizational roles. - Introduced helper functions for checking permissions and retrieving chat information. - Added integration tests to validate access control logic, covering various scenarios including direct permissions, collection permissions, and user roles. - Created unit tests to ensure the correctness of the access control function with mocked database interactions. - Included simple integration tests to verify functionality with existing database data. * sql parser and int tests working. * fix test and lint issues * comment to kick off deployment lo * access controls on datasets * electric context bug fix with sql helpers. * permission and read only * Add lru-cache dependency and export cache management functions - Added `lru-cache` as a dependency in the access-controls package. - Exported new cache management functions from `chats-cached` module, including `canUserAccessChatCached`, `getCacheStats`, `resetCacheStats`, `clearCache`, `invalidateAccess`, `invalidateUserAccess`, and `invalidateChatAccess`. * packages deploy as well * wrong workflow lol * Update AppVerticalCodeSplitter.tsx * Add error handling for query run and SQL save operations Co-authored-by: natemkelley <natemkelley@gmail.com> * Trim whitespace from input values before sending chat prompts Co-authored-by: natemkelley <natemkelley@gmail.com> * type in think-and-prep * use the cached access chat * update package version * new asset import message * Error fallback for login * Update BusterChart.BarChart.stories.tsx * Staging changes to fix number card titles, combo chart axis, and using dynamic filters (#386) Co-authored-by: Jacob Anderson <jacobanderson@Jacobs-MacBook-Air.local> * db init command pass through * combo chart fixes (#387) Co-authored-by: Jacob Anderson <jacobanderson@Jacobs-MacBook-Air.local> * clarifying question and connection logic * pino pretty error fix * clarifying is a finishing tool * change update latest version logic * Update support endpoint * fixes for horizontal bar charts and added the combo chart logic to update metrics (#388) Co-authored-by: Jacob Anderson <jacobanderson@Jacobs-MacBook-Air.local> * permission fix on dashboard metric handlers for workspace and data admin * Add more try catches * Hide avatar is no more * Horizontal bar fixes (#389) * fixes for horizontal bar charts and added the combo chart logic to update metrics * hopefully fixed horizontal bar charts --------- Co-authored-by: Jacob Anderson <jacobanderson@Jacobs-MacBook-Air.local> * reasoning shimmer update * Make the embed flow work with versions * new account warning update * Move support modal * compact number for pie label * Add final reasoning message tracking and workflow start time to chunk processor and related steps - Introduced `finalReasoningMessage` to schemas in `analyst-step`, `mark-message-complete-step`, and `create-todos-step`. - Updated `ChunkProcessor` to calculate and store the final reasoning message based on workflow duration. - Enhanced various steps to utilize the new `workflowStartTime` for better tracking of execution duration. - Improved database update logic to include `finalReasoningMessage` when applicable. * 9 digit cutoff for pie * trigger update * test on mastra braintrust * test deployment * testing * pnpm install * pnpm * node 22 * pnpm version * trigger main * get initial chat file * hono main deploymenbt * clear timeouts * Remove console logs * migration test to staging * db url * try again * k get rid of tls var * hmmm lets try this * mark migrations * fix migration file? * drizzle-kit upgrade * tweaks to the github actions --------- Co-authored-by: Nate Kelley <nate@buster.so> Co-authored-by: porter-deployment-app[bot] <87230664+porter-deployment-app[bot]@users.noreply.github.com> Co-authored-by: Nate Kelley <133379588+nate-kelley-buster@users.noreply.github.com> Co-authored-by: Jacob Anderson <jacobanderson@Jacobs-MacBook-Air.local> Co-authored-by: jacob-buster <jacob@buster.so> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: natemkelley <natemkelley@gmail.com>
2025-07-03 05:33:40 +08:00
import { randomUUID } from 'node:crypto';
import type { RuntimeContext } from '@mastra/core/runtime-context';
import { afterEach, beforeEach, describe, expect, test } from 'vitest';
import { createMetrics } from '../../../src/tools/visualization-tools/create-metrics-file-tool';
import { validateArrayAccess } from '../../../src/utils/validation-helpers';
describe('Create Metrics File Tool Integration Tests', () => {
let mockRuntimeContext: Record<string, unknown>;
let testDataSourceId: string;
let testUserId: string;
let testOrgId: string;
beforeEach(() => {
// Use real test environment IDs
testDataSourceId = 'cc3ef3bc-44ec-4a43-8dc4-681cae5c996a';
testUserId = '1fe85021-e799-471b-8837-953e9ae06e4c';
testOrgId = 'bf58d19a-8bb9-4f1d-a257-2d2105e7f1ce';
mockRuntimeContext = {
get: (key: string) => {
const values: Record<string, string> = {
dataSourceId: testDataSourceId,
data_source_syntax: 'postgresql',
user_id: testUserId,
organization_id: testOrgId,
};
return values[key];
},
};
});
afterEach(async () => {
// Clean up any test data - but only if the tests actually created records
// For now, most tests will fail at database insertion due to FK constraints
// which is expected in this test environment
});
test('should have correct tool configuration', () => {
expect(createMetrics.id).toBe('create-metrics-file');
expect(createMetrics.description).toContain('Creates metric configuration files');
expect(createMetrics.inputSchema).toBeDefined();
expect(createMetrics.outputSchema).toBeDefined();
expect(createMetrics.execute).toBeDefined();
});
test('should validate tool input schema', () => {
const validInput = {
files: [
{
name: 'Integration Test Metric',
yml_content: `
name: Integration Test Metric
description: A metric for integration testing
timeFrame: Last 30 days
sql: |
SELECT
product_name,
COUNT(*) as order_count
FROM sales
WHERE order_date >= CURRENT_DATE - INTERVAL '30 days'
GROUP BY product_name
chartConfig:
selectedChartType: table
columnLabelFormats:
product_name:
columnType: string
style: string
numberSeparatorStyle: null
replaceMissingDataWith: null
order_count:
columnType: number
style: number
numberSeparatorStyle: ","
replaceMissingDataWith: 0
`,
},
],
};
const result = createMetrics.inputSchema.safeParse(validInput);
expect(result.success).toBe(true);
});
test('should validate tool output schema', () => {
const validOutput = {
message: 'Successfully created 1 metric files.',
duration: 1000,
files: [
{
id: randomUUID(),
name: 'Test Metric',
file_type: 'metric',
yml_content: 'name: Test',
created_at: new Date().toISOString(),
updated_at: new Date().toISOString(),
version_number: 1,
},
],
failed_files: [],
};
const result = createMetrics.outputSchema.safeParse(validOutput);
expect(result.success).toBe(true);
});
test('should handle runtime context requirements', async () => {
const contextWithoutDataSource = {
get: (key: string) => {
if (key === 'dataSourceId') return undefined;
return 'test-value';
},
};
const validYaml = `
name: Test
description: Test
timeFrame: Today
sql: SELECT * FROM test
chartConfig:
selectedChartType: table
columnLabelFormats:
test:
columnType: string
style: string
numberSeparatorStyle: null
replaceMissingDataWith: null
`;
const input = {
files: [{ name: 'Test', yml_content: validYaml }],
runtimeContext: contextWithoutDataSource,
};
await expect(
createMetrics.execute({
context: input,
runtimeContext: contextWithoutDataSource as unknown as RuntimeContext,
})
).rejects.toThrow('Data source ID not found in runtime context');
});
test('should reject invalid YAML in integration context', async () => {
const invalidYaml = `
name: Invalid Metric
description: Invalid metric
# Missing timeFrame and sql
chartConfig:
selectedChartType: table
columnLabelFormats:
test:
columnType: string
style: string
numberSeparatorStyle: null
replaceMissingDataWith: null
`;
const input = {
files: [{ name: 'Invalid Metric', yml_content: invalidYaml }],
runtimeContext: mockRuntimeContext,
};
const result = await createMetrics.execute({
context: input,
runtimeContext: mockRuntimeContext as unknown as RuntimeContext,
});
expect(result.files).toHaveLength(0);
expect(result.failed_files).toHaveLength(1);
expect(validateArrayAccess(result.failed_files, 0, 'failed_files')?.name).toBe(
'Invalid Metric'
);
expect(validateArrayAccess(result.failed_files, 0, 'failed_files')?.error).toContain(
'Invalid YAML structure'
);
});
test('should reject invalid SQL in integration context', async () => {
const invalidSqlYaml = `
name: Invalid SQL
description: Test with invalid SQL
timeFrame: Today
sql: INSERT INTO test VALUES (1, 'invalid')
chartConfig:
selectedChartType: table
columnLabelFormats:
test:
columnType: string
style: string
numberSeparatorStyle: null
replaceMissingDataWith: null
`;
const input = {
files: [{ name: 'Invalid SQL', yml_content: invalidSqlYaml }],
runtimeContext: mockRuntimeContext,
};
const result = await createMetrics.execute({
context: input,
runtimeContext: mockRuntimeContext as unknown as RuntimeContext,
});
expect(result.files).toHaveLength(0);
expect(result.failed_files).toHaveLength(1);
expect(validateArrayAccess(result.failed_files, 0, 'failed_files')?.name).toBe('Invalid SQL');
expect(validateArrayAccess(result.failed_files, 0, 'failed_files')?.error).toContain(
'SQL query must contain SELECT statement'
);
});
test('should handle mixed success and failure scenarios', async () => {
const validYamlStructure = `
name: Valid Metric
description: This has valid YAML structure
timeFrame: Today
sql: SELECT COUNT(*) as count FROM valid_table
chartConfig:
selectedChartType: table
columnLabelFormats:
count:
columnType: number
style: number
numberSeparatorStyle: null
replaceMissingDataWith: 0
`;
const invalidYaml = `
name: Invalid Metric
description: This should fail YAML validation
timeFrame: Today
sql: # Empty SQL should fail validation
chartConfig:
selectedChartType: table
columnLabelFormats:
test:
columnType: string
style: string
numberSeparatorStyle: null
replaceMissingDataWith: null
`;
const input = {
files: [
{ name: 'Valid YAML Structure', yml_content: validYamlStructure },
{ name: 'Invalid Metric', yml_content: invalidYaml },
],
runtimeContext: mockRuntimeContext,
};
const result = await createMetrics.execute({
context: input,
runtimeContext: mockRuntimeContext as unknown as RuntimeContext,
});
// Should have one success and one failure
expect(result.files).toHaveLength(1);
expect(result.failed_files).toHaveLength(1);
// The success should be the valid YAML structure (name comes from YAML content)
expect(validateArrayAccess(result.files, 0, 'files')?.name).toBe('Valid Metric');
// The failure should be due to YAML validation (empty sql)
const yamlFailure = result.failed_files.find((f) => f.name === 'Invalid Metric');
expect(yamlFailure?.error).toContain('Invalid YAML structure');
});
test('should properly format response timing', async () => {
const validYaml = `
name: Timing Test
description: Test response timing
timeFrame: Today
sql: SELECT * FROM timing_test
chartConfig:
selectedChartType: table
columnLabelFormats:
test:
columnType: string
style: string
numberSeparatorStyle: null
replaceMissingDataWith: null
`;
const input = {
files: [{ name: 'Timing Test', yml_content: validYaml }],
runtimeContext: mockRuntimeContext,
};
const result = await createMetrics.execute({
context: input,
runtimeContext: mockRuntimeContext as unknown as RuntimeContext,
});
expect(result.duration).toBeGreaterThan(0);
expect(typeof result.duration).toBe('number');
expect(result.duration).toBeLessThan(10000); // Should complete within 10 seconds
});
test('should handle bulk operations correctly', async () => {
const createMetricYaml = (index: number) => `
name: Bulk Metric ${index}
description: Metric ${index} for bulk testing
timeFrame: Last ${index} days
sql: SELECT COUNT(*) as count_${index} FROM table_${index}
chartConfig:
selectedChartType: table
columnLabelFormats:
count_${index}:
columnType: number
style: number
numberSeparatorStyle: null
replaceMissingDataWith: 0
`;
const files = Array.from({ length: 3 }, (_, i) => ({
name: `Bulk Metric ${i + 1}`,
yml_content: createMetricYaml(i + 1),
}));
const input = {
files,
runtimeContext: mockRuntimeContext,
};
const result = await createMetrics.execute({
context: input,
runtimeContext: mockRuntimeContext as unknown as RuntimeContext,
});
expect(result.files).toHaveLength(3);
expect(result.failed_files).toHaveLength(0);
expect(result.message).toBe('Successfully created 3 metric files.');
// Verify all files have proper structure
result.files.forEach((file, index) => {
expect(file.file_type).toBe('metric');
expect(file.version_number).toBe(1);
expect(file.name).toContain('Bulk Metric');
// Note: yml_content is not returned in the file object
});
});
test('should generate appropriate success and error messages', async () => {
// Test success message
const validYaml = `
name: Success Message Test
description: Test success message generation
timeFrame: Today
sql: SELECT * FROM success_test
chartConfig:
selectedChartType: table
columnLabelFormats:
test:
columnType: string
style: string
numberSeparatorStyle: null
replaceMissingDataWith: null
`;
const successInput = {
files: [{ name: 'Success Message Test', yml_content: validYaml }],
runtimeContext: mockRuntimeContext,
};
const successResult = await createMetrics.execute({
context: successInput,
runtimeContext: mockRuntimeContext as unknown as RuntimeContext,
});
expect(successResult.message).toBe('Successfully created 1 metric files.');
// Test failure message
const invalidYaml = 'invalid yaml structure';
const failureInput = {
files: [{ name: 'Failure Test', yml_content: invalidYaml }],
runtimeContext: mockRuntimeContext,
};
const failureResult = await createMetrics.execute({
context: failureInput,
runtimeContext: mockRuntimeContext as unknown as RuntimeContext,
});
expect(failureResult.message).toContain("Failed to create 'Failure Test'");
expect(failureResult.message).toContain('Please recreate the metric from scratch');
});
});