From 098b54103dc24e25879201e63aa1dc938ce7c4e0 Mon Sep 17 00:00:00 2001
From: Wells Bunker <wells@buster.so>
Date: Wed, 1 Oct 2025 10:53:45 -0600
Subject: [PATCH] minor fixes

---
 apps/server/src/api/v2/metric_files/[id]/screenshot/PUT.ts | 4 ----
 apps/server/src/api/v2/reports/[id]/screenshot/PUT.ts      | 3 ---
 packages/server-shared/src/screenshots/screenshots.ts      | 4 ++--
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/apps/server/src/api/v2/metric_files/[id]/screenshot/PUT.ts b/apps/server/src/api/v2/metric_files/[id]/screenshot/PUT.ts
index 04e163dca..0643f70ee 100644
--- a/apps/server/src/api/v2/metric_files/[id]/screenshot/PUT.ts
+++ b/apps/server/src/api/v2/metric_files/[id]/screenshot/PUT.ts
@@ -39,10 +39,6 @@ const app = new Hono().put(
       });
     }
 
-    if (!assetId) {
-      throw new HTTPException(404, { message: 'Metric not found' });
-    }
-
     const result: PutScreenshotResponse = await uploadScreenshotHandler({
       assetType: 'metric_file',
       assetId,
diff --git a/apps/server/src/api/v2/reports/[id]/screenshot/PUT.ts b/apps/server/src/api/v2/reports/[id]/screenshot/PUT.ts
index aa08890b2..9fe543856 100644
--- a/apps/server/src/api/v2/reports/[id]/screenshot/PUT.ts
+++ b/apps/server/src/api/v2/reports/[id]/screenshot/PUT.ts
@@ -20,9 +20,6 @@ const app = new Hono().put(
     const user = c.get('busterUser');
 
     const report = await getReportFileById({ reportId: assetId, userId: user.id });
-    if (!report) {
-      throw new HTTPException(404, { message: 'Report not found' });
-    }
 
     if (!report) {
       throw new HTTPException(404, { message: 'Report not found' });
diff --git a/packages/server-shared/src/screenshots/screenshots.ts b/packages/server-shared/src/screenshots/screenshots.ts
index dff5b1f1d..63df78da5 100644
--- a/packages/server-shared/src/screenshots/screenshots.ts
+++ b/packages/server-shared/src/screenshots/screenshots.ts
@@ -11,7 +11,7 @@ export const PutScreenshotRequestSchema = z.object({
 export type PutScreenshotRequest = z.infer<typeof PutScreenshotRequestSchema>;
 
 export const PutScreenshotResponseSchema = z.object({
-  success: z.literal(true),
+  success: z.boolean(),
   bucketKey: z.string().min(1, 'Bucket key is required'),
 });
 
@@ -19,7 +19,7 @@ export type PutScreenshotResponse = z.infer<typeof PutScreenshotResponseSchema>;
 
 export const GetScreenshotResponseSchema = z.object({
   success: z.boolean(),
-  url: z.string().url(),
+  url: z.string(),
 });
 
 export type GetScreenshotResponse = z.infer<typeof GetScreenshotResponseSchema>;