From a6e5ade68ddaecea69aff9ff719f0f8e48ec9aa8 Mon Sep 17 00:00:00 2001 From: dal Date: Mon, 14 Apr 2025 13:21:20 -0600 Subject: [PATCH 1/2] 4.1 mini see if anyone notices --- api/libs/agents/src/agent.rs | 2 ++ api/libs/agents/src/agents/buster_multi_agent.rs | 2 +- .../categories/file_tools/create_dashboards.rs | 1 + .../tools/categories/file_tools/create_metrics.rs | 1 + .../categories/file_tools/modify_dashboards.rs | 14 ++++++-------- .../tools/categories/file_tools/modify_metrics.rs | 1 + 6 files changed, 12 insertions(+), 9 deletions(-) diff --git a/api/libs/agents/src/agent.rs b/api/libs/agents/src/agent.rs index 8bd44e8b7..904a24499 100644 --- a/api/libs/agents/src/agent.rs +++ b/api/libs/agents/src/agent.rs @@ -605,6 +605,8 @@ impl Agent { session_id: thread.id.to_string(), trace_id: Uuid::new_v4().to_string(), }), + temperature: Some(0.0), + max_completion_tokens: Some(15000), // reasoning_effort: Some("low".to_string()), ..Default::default() }; diff --git a/api/libs/agents/src/agents/buster_multi_agent.rs b/api/libs/agents/src/agents/buster_multi_agent.rs index a2bbc7859..b4228fc21 100644 --- a/api/libs/agents/src/agents/buster_multi_agent.rs +++ b/api/libs/agents/src/agents/buster_multi_agent.rs @@ -206,7 +206,7 @@ impl BusterMultiAgent { // Create agent, passing the selected initialization prompt as default let agent = Arc::new(Agent::new( - "o3-mini".to_string(), + "gpt-4.1".to_string(), user_id, session_id, "buster_multi_agent".to_string(), diff --git a/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs b/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs index 38b5d35cb..76aeeda49 100644 --- a/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs +++ b/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs @@ -328,6 +328,7 @@ impl ToolExecutor for CreateDashboardFilesTool { "items": { "type": "object", "required": ["name", "yml_content"], + "strict": true, "properties": { "name": { "type": "string", diff --git a/api/libs/agents/src/tools/categories/file_tools/create_metrics.rs b/api/libs/agents/src/tools/categories/file_tools/create_metrics.rs index 7d2584d65..dc236f5b4 100644 --- a/api/libs/agents/src/tools/categories/file_tools/create_metrics.rs +++ b/api/libs/agents/src/tools/categories/file_tools/create_metrics.rs @@ -264,6 +264,7 @@ impl ToolExecutor for CreateMetricFilesTool { "items": { "type": "object", "required": ["name", "yml_content"], + "strict": true, "properties": { "name": { "type": "string", diff --git a/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs b/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs index ec4943fa9..da3dce7c4 100644 --- a/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs +++ b/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs @@ -16,8 +16,8 @@ use tracing::{debug, error, info}; use super::{ common::{ - process_dashboard_file_modification, ModificationResult, ModifyFilesOutput, - ModifyFilesParams, FailedFileModification, + process_dashboard_file_modification, FailedFileModification, ModificationResult, + ModifyFilesOutput, ModifyFilesParams, }, file_types::file::FileWithId, FileModificationTool, @@ -230,16 +230,13 @@ impl ToolExecutor for ModifyDashboardFilesTool { "description": get_modify_dashboards_yml_description().await, "items": { "type": "object", - "required": ["id", "file_name", "modifications"], + "required": ["id", "modifications"], + "strict": true, "properties": { "id": { "type": "string", "description": get_dashboard_modification_id_description().await }, - "file_name": { - "type": "string", - "description": get_modify_dashboards_file_name_description().await - }, "modifications": { "type": "array", "description": get_modify_dashboards_modifications_description().await, @@ -490,7 +487,8 @@ mod tests { #[test] fn test_apply_modifications_append() { - let original_content = "name: test_dashboard\ntype: dashboard\ndescription: A test dashboard"; + let original_content = + "name: test_dashboard\ntype: dashboard\ndescription: A test dashboard"; // Test appending content with empty content_to_replace let mods = vec![Modification { diff --git a/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs b/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs index 5b3ca97f7..72a14104b 100644 --- a/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs +++ b/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs @@ -328,6 +328,7 @@ impl ToolExecutor for ModifyMetricFilesTool { "content_to_replace", "new_content" ], + "strict": true, "properties": { "content_to_replace": { "type": "string", From a6f7950b6de2ab27601d660d976d9505db61bbb8 Mon Sep 17 00:00:00 2001 From: dal Date: Mon, 14 Apr 2025 13:24:09 -0600 Subject: [PATCH 2/2] o3-mini for a bit more testing before o1 --- api/libs/agents/src/agent.rs | 4 ++-- api/libs/agents/src/agents/buster_multi_agent.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/api/libs/agents/src/agent.rs b/api/libs/agents/src/agent.rs index 904a24499..5b0fd7792 100644 --- a/api/libs/agents/src/agent.rs +++ b/api/libs/agents/src/agent.rs @@ -605,8 +605,8 @@ impl Agent { session_id: thread.id.to_string(), trace_id: Uuid::new_v4().to_string(), }), - temperature: Some(0.0), - max_completion_tokens: Some(15000), + // temperature: Some(0.0), + // max_completion_tokens: Some(15000), // reasoning_effort: Some("low".to_string()), ..Default::default() }; diff --git a/api/libs/agents/src/agents/buster_multi_agent.rs b/api/libs/agents/src/agents/buster_multi_agent.rs index b4228fc21..a2bbc7859 100644 --- a/api/libs/agents/src/agents/buster_multi_agent.rs +++ b/api/libs/agents/src/agents/buster_multi_agent.rs @@ -206,7 +206,7 @@ impl BusterMultiAgent { // Create agent, passing the selected initialization prompt as default let agent = Arc::new(Agent::new( - "gpt-4.1".to_string(), + "o3-mini".to_string(), user_id, session_id, "buster_multi_agent".to_string(),