Ling0925
/
buster
mirror of https://github.com/buster-so/buster.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

update y axis to be more efficient

This commit is contained in:
Nate Kelley 2025-09-23 15:21:41 -06:00
parent 98e87bc2f4
commit 1326aab1a6
No known key found for this signature in database
GPG Key ID: FD90372AB8D98B4F
1 changed files with 27 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
apps/web/src/components/ui/charts/BusterChartJS/hooks/useOptions/useYAxis.ts
View File

@ -57,28 +57,39 @@ export const useYAxis = ({
const checkVales = [...yAxisKeys, ...y2AxisKeys];
const isAllBarValues = checkVales.every((key) => {
return columnMetadata?.some((column) => {
return (
column.name === key &&
(columnSettings[column.name]?.columnVisualization ||
DEFAULT_COLUMN_SETTINGS.columnVisualization) === 'bar'
);
});
});
// Create lookup map for O(1) column access
const columnMap = new Map(columnMetadata.map((col) => [col.name, col]));
if (isAllBarValues) return true;
let allBarValues = true;
let hasNegativeValues = false;
const hasNegativeValues = checkVales.some((key) => {
return columnMetadata?.some((column) => {
return column.name === key && Number(column.min_value ?? 0) < 0;
});
});
// Single pass to check both conditions
for (const key of checkVales) {
const column = columnMap.get(key);
if (!column) {
allBarValues = false;
continue;
}
// Check if this column is a bar
const visualization =
columnSettings[column.name]?.columnVisualization ||
DEFAULT_COLUMN_SETTINGS.columnVisualization;
if (visualization !== 'bar') {
allBarValues = false;
}
// Check if this column has negative values
if (Number(column.min_value ?? 0) < 0) {
hasNegativeValues = true;
}
}
if (allBarValues) return true;
if (hasNegativeValues) return false;
return false;
}, [hasY2Axis, yAxisKeys, selectedChartType]);
}, [hasY2Axis, yAxisKeys, y2AxisKeys, selectedChartType, columnMetadata, columnSettings]);
const isSupportedType = useMemo(() => {
return selectedChartType !== 'pie';