From 1513a39268471ee9060f1e279341aa7b80367612 Mon Sep 17 00:00:00 2001
From: dal <dallin@buster.so>
Date: Fri, 21 Mar 2025 10:44:53 -0600
Subject: [PATCH] clean up

---
 api/libs/agents/src/agent.rs                             | 4 ++--
 .../agents/src/tools/categories/file_tools/common.rs     | 4 ++--
 .../src/tools/categories/file_tools/create_dashboards.rs | 2 +-
 .../src/tools/categories/file_tools/modify_dashboards.rs | 2 +-
 .../src/tools/categories/file_tools/modify_metrics.rs    | 9 +++------
 .../handlers/src/chats/sharing/create_sharing_handler.rs | 2 +-
 .../handlers/src/chats/sharing/list_sharing_handler.rs   | 2 +-
 .../src/collections/add_assets_to_collection_handler.rs  | 4 ++--
 .../collections/add_dashboards_to_collection_handler.rs  | 6 +++---
 .../remove_metrics_from_collection_handler.rs            | 6 +++---
 .../src/collections/update_collection_handler.rs         | 2 +-
 .../handlers/src/dashboards/create_dashboard_handler.rs  | 4 ++--
 .../src/dashboards/sharing/create_sharing_handler.rs     | 6 +++---
 .../src/metrics/add_metric_to_collections_handler.rs     | 6 +++---
 api/libs/handlers/src/metrics/delete_metric_handler.rs   | 6 +++---
 .../src/metrics/post_metric_dashboard_handler.rs         | 6 +++---
 .../src/metrics/sharing/delete_sharing_handler.rs        | 2 +-
 .../handlers/tests/metrics/post_metric_dashboard_test.rs | 4 ++--
 api/libs/handlers/tests/metrics/update_metric_test.rs    | 1 -
 api/libs/sharing/src/check_asset_permission.rs           | 6 +++---
 api/libs/sharing/src/create_asset_permission.rs          | 4 ++--
 api/libs/sharing/src/remove_asset_permissions.rs         | 2 +-
 22 files changed, 43 insertions(+), 47 deletions(-)

diff --git a/api/libs/agents/src/agent.rs b/api/libs/agents/src/agent.rs
index f4778769a..e709b2cfc 100644
--- a/api/libs/agents/src/agent.rs
+++ b/api/libs/agents/src/agent.rs
@@ -1100,7 +1100,7 @@ mod tests {
         setup();
 
         // Create agent first
-        let mut agent = Agent::new(
+        let agent = Agent::new(
             "o1".to_string(),
             HashMap::new(),
             Uuid::new_v4(),
@@ -1133,7 +1133,7 @@ mod tests {
         setup();
 
         // Create LLM client and agent
-        let mut agent = Agent::new(
+        let agent = Agent::new(
             "o1".to_string(),
             HashMap::new(),
             Uuid::new_v4(),
diff --git a/api/libs/agents/src/tools/categories/file_tools/common.rs b/api/libs/agents/src/tools/categories/file_tools/common.rs
index 23f5f8210..1337dcaf5 100644
--- a/api/libs/agents/src/tools/categories/file_tools/common.rs
+++ b/api/libs/agents/src/tools/categories/file_tools/common.rs
@@ -1058,9 +1058,9 @@ mod tests {
     use chrono::Utc;
     use database::{
         models::DashboardFile,
-        types::{DashboardYml, Version},
+        types::DashboardYml,
     };
-    use serde_json::json;
+    
     use uuid::Uuid;
 
     // Mock functions for testing
diff --git a/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs b/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs
index 217f11670..10b4b6569 100644
--- a/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs
+++ b/api/libs/agents/src/tools/categories/file_tools/create_dashboards.rs
@@ -15,7 +15,7 @@ use database::{
 use diesel::insert_into;
 use diesel_async::RunQueryDsl;
 use serde::{Deserialize, Serialize};
-use serde_json::{self, json, Value};
+use serde_json::{self, Value};
 use tracing::debug;
 use uuid::Uuid;
 
diff --git a/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs b/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs
index 1a83e2b69..f0df48819 100644
--- a/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs
+++ b/api/libs/agents/src/tools/categories/file_tools/modify_dashboards.rs
@@ -16,7 +16,7 @@ use tracing::{debug, error, info};
 
 use super::{
     common::{
-        apply_modifications_to_content, FileModificationBatch, ModificationResult,
+        ModificationResult,
         ModifyFilesOutput, ModifyFilesParams, process_dashboard_file_modification,
     },
     file_types::file::FileWithId,
diff --git a/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs b/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs
index 8e65c8596..83d538900 100644
--- a/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs
+++ b/api/libs/agents/src/tools/categories/file_tools/modify_metrics.rs
@@ -3,24 +3,21 @@ use std::{env, sync::Arc, time::Instant};
 use anyhow::Result;
 use async_trait::async_trait;
 use braintrust::{get_prompt_system_message, BraintrustClient};
-use chrono::Utc;
 use database::{
-    enums::Verification, models::MetricFile, pool::get_pg_pool, schema::metric_files,
+    models::MetricFile, pool::get_pg_pool, schema::metric_files,
     types::MetricYml,
 };
 use diesel::{upsert::excluded, ExpressionMethods, QueryDsl};
 use diesel_async::RunQueryDsl;
 use indexmap::IndexMap;
 use query_engine::data_types::DataType;
-use serde::{Deserialize, Serialize};
 use serde_json::Value;
 use tracing::{debug, error, info};
 use uuid::Uuid;
 
 use super::{
     common::{
-        apply_modifications_to_content, process_metric_file_modification, FileModification,
-        FileModificationBatch, Modification, ModificationResult, ModifyFilesOutput,
+        process_metric_file_modification, ModificationResult, ModifyFilesOutput,
         ModifyFilesParams,
     },
     file_types::file::FileWithId,
@@ -160,7 +157,7 @@ impl ToolExecutor for ModifyMetricFilesTool {
 
         // Process results and generate output message
         let duration = start_time.elapsed().as_millis() as i64;
-        let mut output = ModifyFilesOutput {
+        let output = ModifyFilesOutput {
             message: String::new(),
             files: Vec::new(),
             duration,
diff --git a/api/libs/handlers/src/chats/sharing/create_sharing_handler.rs b/api/libs/handlers/src/chats/sharing/create_sharing_handler.rs
index b4edddc76..77d74ae90 100644
--- a/api/libs/handlers/src/chats/sharing/create_sharing_handler.rs
+++ b/api/libs/handlers/src/chats/sharing/create_sharing_handler.rs
@@ -84,7 +84,7 @@ pub async fn get_chat_exists(chat_id: &Uuid) -> Result<bool> {
 mod tests {
     use super::*;
     use database::enums::{AssetPermissionRole, AssetType, IdentityType};
-    use sharing::create_share;
+    
     use uuid::Uuid;
 
     // Mock function to test permission checking
diff --git a/api/libs/handlers/src/chats/sharing/list_sharing_handler.rs b/api/libs/handlers/src/chats/sharing/list_sharing_handler.rs
index ec1a9ada2..19b0197d9 100644
--- a/api/libs/handlers/src/chats/sharing/list_sharing_handler.rs
+++ b/api/libs/handlers/src/chats/sharing/list_sharing_handler.rs
@@ -110,7 +110,7 @@ pub async fn list_chat_sharing_handler(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
+    
     
     #[tokio::test]
     async fn test_list_chat_sharing_handler() {
diff --git a/api/libs/handlers/src/collections/add_assets_to_collection_handler.rs b/api/libs/handlers/src/collections/add_assets_to_collection_handler.rs
index 8a6273345..e7e7cc4b6 100644
--- a/api/libs/handlers/src/collections/add_assets_to_collection_handler.rs
+++ b/api/libs/handlers/src/collections/add_assets_to_collection_handler.rs
@@ -435,8 +435,8 @@ pub async fn add_assets_to_collection_handler(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use uuid::Uuid;
+    
+    
 
     #[tokio::test]
     async fn test_add_assets_to_collection_handler() {
diff --git a/api/libs/handlers/src/collections/add_dashboards_to_collection_handler.rs b/api/libs/handlers/src/collections/add_dashboards_to_collection_handler.rs
index b3839ca77..7d5a6142b 100644
--- a/api/libs/handlers/src/collections/add_dashboards_to_collection_handler.rs
+++ b/api/libs/handlers/src/collections/add_dashboards_to_collection_handler.rs
@@ -220,9 +220,9 @@ pub async fn add_dashboards_to_collection_handler(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use database::enums::{AssetPermissionRole, AssetType, IdentityType};
-    use uuid::Uuid;
+    
+    
+    
 
     #[tokio::test]
     async fn test_add_dashboards_to_collection_handler() {
diff --git a/api/libs/handlers/src/collections/remove_metrics_from_collection_handler.rs b/api/libs/handlers/src/collections/remove_metrics_from_collection_handler.rs
index 97df60b5a..b4febf1c9 100644
--- a/api/libs/handlers/src/collections/remove_metrics_from_collection_handler.rs
+++ b/api/libs/handlers/src/collections/remove_metrics_from_collection_handler.rs
@@ -121,9 +121,9 @@ pub async fn remove_metrics_from_collection_handler(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use database::enums::{AssetPermissionRole, AssetType, IdentityType};
-    use uuid::Uuid;
+    
+    
+    
 
     #[tokio::test]
     async fn test_remove_metrics_from_collection_handler() {
diff --git a/api/libs/handlers/src/collections/update_collection_handler.rs b/api/libs/handlers/src/collections/update_collection_handler.rs
index 683b51cf2..322d7d2f2 100644
--- a/api/libs/handlers/src/collections/update_collection_handler.rs
+++ b/api/libs/handlers/src/collections/update_collection_handler.rs
@@ -186,7 +186,7 @@ async fn update_collection_record(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use database::models::Collection;
+    
     use std::sync::Once;
     use uuid::Uuid;
 
diff --git a/api/libs/handlers/src/dashboards/create_dashboard_handler.rs b/api/libs/handlers/src/dashboards/create_dashboard_handler.rs
index 560ebef26..8435d1ca5 100644
--- a/api/libs/handlers/src/dashboards/create_dashboard_handler.rs
+++ b/api/libs/handlers/src/dashboards/create_dashboard_handler.rs
@@ -132,8 +132,8 @@ pub async fn create_dashboard_handler(user_id: &Uuid) -> Result<BusterDashboardR
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use uuid::Uuid;
+    
+    
 
     #[tokio::test]
     async fn test_create_dashboard_handler() {
diff --git a/api/libs/handlers/src/dashboards/sharing/create_sharing_handler.rs b/api/libs/handlers/src/dashboards/sharing/create_sharing_handler.rs
index d18551864..d6c40b7fe 100644
--- a/api/libs/handlers/src/dashboards/sharing/create_sharing_handler.rs
+++ b/api/libs/handlers/src/dashboards/sharing/create_sharing_handler.rs
@@ -128,9 +128,9 @@ pub async fn create_dashboard_sharing_handler(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use database::enums::AssetPermissionRole;
-    use uuid::Uuid;
+    
+    
+    
 
     #[tokio::test]
     async fn test_create_dashboard_sharing_handler() {
diff --git a/api/libs/handlers/src/metrics/add_metric_to_collections_handler.rs b/api/libs/handlers/src/metrics/add_metric_to_collections_handler.rs
index b0a03a965..290e20765 100644
--- a/api/libs/handlers/src/metrics/add_metric_to_collections_handler.rs
+++ b/api/libs/handlers/src/metrics/add_metric_to_collections_handler.rs
@@ -220,9 +220,9 @@ pub async fn add_metric_to_collections_handler(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use database::enums::{AssetPermissionRole, AssetType, IdentityType};
-    use uuid::Uuid;
+    
+    
+    
 
     #[tokio::test]
     async fn test_add_metric_to_collections_handler() {
diff --git a/api/libs/handlers/src/metrics/delete_metric_handler.rs b/api/libs/handlers/src/metrics/delete_metric_handler.rs
index b1fe78823..d1e90afb3 100644
--- a/api/libs/handlers/src/metrics/delete_metric_handler.rs
+++ b/api/libs/handlers/src/metrics/delete_metric_handler.rs
@@ -128,9 +128,9 @@ pub async fn delete_metrics_handler(request: DeleteMetricsRequest, _user_id: &Uu
 #[cfg(test)]
 mod tests {
     use super::*;
-    use diesel::result::Error as DieselError;
-    use mockall::predicate::*;
-    use mockall::mock;
+    
+    
+    
 
     // We removed the problematic mock implementation that was causing compilation errors
     // The real database connection will be mocked in integration tests
diff --git a/api/libs/handlers/src/metrics/post_metric_dashboard_handler.rs b/api/libs/handlers/src/metrics/post_metric_dashboard_handler.rs
index 7807f5b42..05525f611 100644
--- a/api/libs/handlers/src/metrics/post_metric_dashboard_handler.rs
+++ b/api/libs/handlers/src/metrics/post_metric_dashboard_handler.rs
@@ -116,9 +116,9 @@ pub async fn post_metric_dashboard_handler(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use diesel::result::Error as DieselError;
-    use mockall::predicate::*;
-    use mockall::mock;
+    
+    
+    
 
     // We removed the problematic mock implementation that was causing compilation errors
     // The real database operations will be tested in integration tests
diff --git a/api/libs/handlers/src/metrics/sharing/delete_sharing_handler.rs b/api/libs/handlers/src/metrics/sharing/delete_sharing_handler.rs
index 0ddff65be..11a4c0737 100644
--- a/api/libs/handlers/src/metrics/sharing/delete_sharing_handler.rs
+++ b/api/libs/handlers/src/metrics/sharing/delete_sharing_handler.rs
@@ -79,7 +79,7 @@ pub async fn delete_metric_sharing_handler(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
+    
 
     #[tokio::test]
     async fn test_delete_metric_sharing_handler() {
diff --git a/api/libs/handlers/tests/metrics/post_metric_dashboard_test.rs b/api/libs/handlers/tests/metrics/post_metric_dashboard_test.rs
index 11ebc5b0c..dfde64da8 100644
--- a/api/libs/handlers/tests/metrics/post_metric_dashboard_test.rs
+++ b/api/libs/handlers/tests/metrics/post_metric_dashboard_test.rs
@@ -1,6 +1,6 @@
 use anyhow::Result;
 use database::{
-    enums::{AssetType, Verification},
+    enums::AssetType,
     pool::get_pg_pool,
     schema::collections_to_assets,
 };
@@ -11,7 +11,7 @@ use uuid::Uuid;
 
 // Import the common setup and test utilities
 use super::{
-    associate_metric_with_dashboard, cleanup_metric_dashboard_associations, 
+    cleanup_metric_dashboard_associations, 
     cleanup_test_data, create_test_dashboard, create_test_metric, 
     insert_test_dashboard, insert_test_metric, setup_test_environment
 };
diff --git a/api/libs/handlers/tests/metrics/update_metric_test.rs b/api/libs/handlers/tests/metrics/update_metric_test.rs
index d66018987..e22619744 100644
--- a/api/libs/handlers/tests/metrics/update_metric_test.rs
+++ b/api/libs/handlers/tests/metrics/update_metric_test.rs
@@ -8,7 +8,6 @@ use database::{
 use diesel::{ExpressionMethods, QueryDsl};
 use diesel_async::RunQueryDsl;
 use handlers::metrics::{update_metric_handler, UpdateMetricRequest};
-use serde_json::Value;
 use uuid::Uuid;
 
 // Import the common setup and test data functions
diff --git a/api/libs/sharing/src/check_asset_permission.rs b/api/libs/sharing/src/check_asset_permission.rs
index d9323f976..fe402fc8b 100644
--- a/api/libs/sharing/src/check_asset_permission.rs
+++ b/api/libs/sharing/src/check_asset_permission.rs
@@ -273,9 +273,9 @@ pub async fn check_permissions(
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use database::enums::{AssetPermissionRole, AssetType, IdentityType};
-    use uuid::Uuid;
+    
+    use database::enums::AssetPermissionRole;
+    
 
     #[tokio::test]
     async fn test_has_permission_logic() {
diff --git a/api/libs/sharing/src/create_asset_permission.rs b/api/libs/sharing/src/create_asset_permission.rs
index 0a498331d..01e56adb5 100644
--- a/api/libs/sharing/src/create_asset_permission.rs
+++ b/api/libs/sharing/src/create_asset_permission.rs
@@ -173,8 +173,8 @@ pub async fn create_shares_bulk(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::errors::SharingError;
-    use database::enums::{AssetPermissionRole, AssetType, IdentityType};
+    
+    use database::enums::{AssetPermissionRole, AssetType};
     use uuid::Uuid;
 
     #[test]
diff --git a/api/libs/sharing/src/remove_asset_permissions.rs b/api/libs/sharing/src/remove_asset_permissions.rs
index 90e4c1e88..59452f964 100644
--- a/api/libs/sharing/src/remove_asset_permissions.rs
+++ b/api/libs/sharing/src/remove_asset_permissions.rs
@@ -98,7 +98,7 @@ pub async fn remove_share_by_email(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use database::enums::{AssetPermissionRole, AssetType, IdentityType};
+    use database::enums::AssetType;
     use uuid::Uuid;
 
     #[test]