From 1dea5d52366cc67139315d9eb892f50d58430359 Mon Sep 17 00:00:00 2001 From: Nate Kelley Date: Wed, 23 Jul 2025 12:02:54 -0600 Subject: [PATCH] fix linting --- packages/ui-components/biome.json | 14 ++++++++- packages/ui-components/package.json | 7 ++--- .../core/plugins/chartjs-plugin-mounted.tsx | 5 ++-- .../core/plugins/chartjs-plugin-totalizer.ts | 7 +++-- .../BusterChartJS/helpers/datalabelHelper.ts | 2 +- .../helpers/formatBarAndLineDataLabel.test.ts | 2 +- .../getLegendItems.test.ts | 4 +-- .../barChartOptions.test.ts | 2 +- .../barChartOptions.ts | 2 +- .../useChartSpecificOptions/interfaces.ts | 2 +- .../useChartSpecificOptions.ts | 30 +++++++++---------- .../hooks/useGoalLines/useGoalLines.test.ts | 12 ++++---- .../useOptions/axisHooks/useY2AxisTitle.ts | 8 ++--- .../hooks/useOptions/useInteractions.test.tsx | 2 +- .../hooks/useOptions/useInteractions.ts | 2 +- .../barAndLineTooltipHelper.test.ts | 2 +- .../pieTooltipHelper.test.ts | 2 +- .../useOptions/useXAxis/useXAxis.test.ts | 14 ++++----- .../hooks/useOptions/useY2Axis.test.ts | 2 +- .../hooks/useOptions/useYAxis.test.ts | 2 +- .../comboSeriesBuilder.test.ts | 2 +- .../useSeriesOptions/comboSeriesBuilder.ts | 10 +++---- .../hooks/useSeriesOptions/interfaces.ts | 2 +- .../charts/BusterChartLegend/helpers.test.tsx | 2 +- .../legendHeadlineHelpers.test.ts | 6 ++-- .../stories/OverflowButton.stories.tsx | 2 +- .../BusterChartTooltip/BusterChartTooltip.tsx | 2 +- .../charts/BusterChartTooltip/TooltipItem.tsx | 4 +-- .../BusterChartTooltip/TooltipTitle.tsx | 2 +- .../aggregateAndCreateDatasets.test.ts | 2 +- .../datasetHelpers_BarLinePie.test.ts | 2 +- .../dataMapper.test.ts | 2 +- .../commonHelpers/pieLabelHelpers.test.ts | 6 ++-- .../src/components/charts/helpers.test.ts | 2 +- .../charts/stories/BusterChartShared.ts | 2 +- .../stories/BusterMetricChart.stories.tsx | 2 +- .../stories/BusterTableChart.stories.tsx | 2 +- .../createDefaultAxis.test.ts | 2 +- .../createDefaultColumnFormats.test.ts | 4 +-- .../createDefaultColumnSettings.test.ts | 2 +- .../createDefaultColumnSettings.ts | 4 +-- .../messageAutoChartHandler.test.ts | 6 ++-- .../TanStackDataGrid/DataGridRow.tsx | 2 +- .../src/lib/columnFormatter.test.ts | 2 +- .../ui-components/src/lib/messages.test.ts | 4 +-- scripts/new-package.ts | 2 +- 46 files changed, 107 insertions(+), 96 deletions(-) diff --git a/packages/ui-components/biome.json b/packages/ui-components/biome.json index b2862a3b2..6db7a8687 100644 --- a/packages/ui-components/biome.json +++ b/packages/ui-components/biome.json @@ -13,5 +13,17 @@ "useKeyWithClickEvents": "off" } } - } + }, + "overrides": [ + { + "include": ["src/components/charts/*"], + "linter": { + "rules": { + "correctness": { + "useExhaustiveDependencies": "off" + } + } + } + } + ] } diff --git a/packages/ui-components/package.json b/packages/ui-components/package.json index 885b41904..8f8df1152 100644 --- a/packages/ui-components/package.json +++ b/packages/ui-components/package.json @@ -12,16 +12,13 @@ "./styles": "./src/styles/styles.css", "./dist/style.css": "./dist/style.css" }, - "files": [ - "dist", - "src/styles/styles.css" - ], + "files": ["dist", "src/styles/styles.css"], "scripts": { "prebuild": "tsx scripts/validate-env.ts", "build": "vite build && tsc --emitDeclarationOnly --declaration", "typecheck": "tsc --noEmit", "dev": "vite build --watch", - "lint": "biome check", + "lint": "biome check --write", "test": "vitest run", "test:watch": "vitest watch", "test:coverage": "vitest run --coverage" diff --git a/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-mounted.tsx b/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-mounted.tsx index 8d87e5106..5190a61fe 100644 --- a/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-mounted.tsx +++ b/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-mounted.tsx @@ -6,6 +6,7 @@ export interface ChartMountedPluginOptions { } declare module 'chart.js' { + // biome-ignore lint/correctness/noUnusedVariables: we need to define the plugin options interface PluginOptionsByType { chartMounted?: ChartMountedPluginOptions; } @@ -18,12 +19,12 @@ declare module 'chart.js' { export const ChartMountedPlugin: Plugin = { id: 'chartMounted', - afterInit: (chart, args, options) => { + afterInit: (chart, _args, options) => { if (!chart || !options) return; options?.onMounted?.(chart); chart.$mountedPlugin = true; }, - afterRender: (chart, args, options) => { + afterRender: (chart, _args, options) => { if (chart.$initialAnimationCompleted === undefined) { chart.$initialAnimationCompleted = true; } diff --git a/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-totalizer.ts b/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-totalizer.ts index c508386e5..129e815d5 100644 --- a/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-totalizer.ts +++ b/packages/ui-components/src/components/charts/BusterChartJS/core/plugins/chartjs-plugin-totalizer.ts @@ -5,6 +5,7 @@ export interface ChartTotalizerPluginOptions { } declare module 'chart.js' { + // biome-ignore lint/correctness/noUnusedVariables: we need to define the plugin options interface PluginOptionsByType { totalizer?: ChartTotalizerPluginOptions | false; } @@ -23,7 +24,7 @@ export const ChartTotalizerPlugin: Plugin { + beforeDatasetsUpdate: (chart, _args, options) => { if (options?.enabled === false) return; const stackTotals: Record = {}; @@ -35,8 +36,8 @@ export const ChartTotalizerPlugin: Plugin