Merge pull request #1273 from buster-so/nate/upgrade-core-biome2

Upgrade core biome2

biome2.json

@@ -78,6 +78,9 @@
           "correctness": {
             "noUnusedFunctionParameters": "off",
             "noUnusedVariables": "off"
+          },
+          "performance": {
+            "noDelete": "off"
           }
         }
       }

packages/test-utils/biome.json

@@ -1,7 +1,7 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.2.5/schema.json",
-  "extends": ["../../biome.json"],
+  "extends": ["../../biome2.json"],
   "files": {
-    "include": ["src/**/*"]
+    "includes": ["src/**/*"]
   }
 }

packages/test-utils/env.d.ts

@@ -10,4 +10,4 @@ declare global {
   }
 }
 
-export {}; 
+export {};

packages/test-utils/package.json

@@ -30,6 +30,7 @@
     "@buster/env-utils": "workspace:*",
     "@buster/typescript-config": "workspace:*",
     "@buster/vitest-config": "workspace:*",
+    "@biomejs/biome": "2.2.5",
     "uuid": "catalog:"
   }
 }

packages/test-utils/src/database/chats/index.ts

@@ -1,2 +1,2 @@
-export * from './createTestChat';
 export * from './cleanupTestChats';
+export * from './createTestChat';

packages/test-utils/src/database/messages/index.ts

@@ -1,3 +1,3 @@
+export * from './cleanupTestMessages';
 export * from './createTestMessage';
 export * from './createTestMessageWithContext';
-export * from './cleanupTestMessages';

packages/test-utils/src/database/organizations/createTestOrganization.ts

@@ -7,9 +7,7 @@ import { v4 as uuidv4 } from 'uuid';
  * @param params - Optional parameters to override defaults
  * @returns The organization ID
  */
-export async function createTestOrganization(params?: {
+export async function createTestOrganization(params?: { name?: string }): Promise<string> {
-  name?: string;
-}): Promise<string> {
   try {
     const organizationId = uuidv4();
     const name = params?.name || `Test Organization ${uuidv4()}`;

packages/test-utils/src/database/users/createTestUser.ts

@@ -7,10 +7,7 @@ import { v4 as uuidv4 } from 'uuid';
  * @param params - Optional parameters to override defaults
  * @returns The user ID
  */
-export async function createTestUser(params?: {
+export async function createTestUser(params?: { email?: string; name?: string }): Promise<string> {
-  email?: string;
-  name?: string;
-}): Promise<string> {
   try {
     const userId = uuidv4();
     const email = params?.email || `test-${uuidv4()}@example.com`;

packages/test-utils/src/envHelpers/env-helpers.test.ts

@@ -1,8 +1,8 @@
 import { describe, expect, it, vi } from 'vitest';
 import {
-  type TestEnvironment,
   cleanupTestEnvironment,
   setupTestEnvironment,
+  type TestEnvironment,
   withTestEnv,
 } from './env-helpers';
 
@@ -140,7 +140,7 @@ describe('env-helpers.ts - Unit Tests', () => {
       }
 
       if (originalCustomVar === undefined) {
-        delete process.env.CUSTOM_VAR;
+        process.env.CUSTOM_VAR = undefined;
       }
     });
 

packages/test-utils/src/envHelpers/env-helpers.ts

@@ -31,8 +31,7 @@ export function withTestEnv<T>(testFn: () => Promise<T>): () => Promise<T> {
   return async () => {
     const originalEnv = { ...process.env };
 
-    // biome-ignore lint/correctness/noUnusedVariables:
+    await setupTestEnvironment();
-    const env = await setupTestEnvironment();
     try {
       return await testFn();
     } finally {

packages/test-utils/src/index.ts

@@ -1,9 +1,10 @@
 // Database test helpers
+
+export * from './database/chats';
+export * from './database/dataSources';
+export * from './database/messages';
 export * from './database/organizations';
 export * from './database/users';
-export * from './database/chats';
-export * from './database/messages';
-export * from './database/dataSources';
 
 export * from './envHelpers';
 

packages/test-utils/src/mock-helpers.ts

@@ -40,7 +40,7 @@ export function createMockDate(fixedDate: string | Date) {
   const mockDate = new Date(fixedDate);
   const originalDate = Date;
 
-  // @ts-ignore
+  // @ts-expect-error
   global.Date = vi.fn(() => mockDate);
   global.Date.now = vi.fn(() => mockDate.getTime());
 

packages/vitest-config/biome.json

@@ -0,0 +1,14 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.2.5/schema.json",
+  "extends": ["../../biome2.json"],
+  "files": {
+    "includes": ["src/**/*", "scripts/**/*", "configs/**/*"]
+  },
+  "linter": {
+    "rules": {
+      "suspicious": {
+        "noConsole": "off"
+      }
+    }
+  }
+}

packages/vitest-config/configs/base-config.ts

@@ -1,6 +1,6 @@
 import { loadEnv } from 'vite';
-import { defineConfig } from 'vitest/config';
 import type { Plugin, ViteUserConfig } from 'vitest/config';
+import { defineConfig } from 'vitest/config';
 
 export const baseConfig = defineConfig(async () => {
   const { default: tsconfigPaths } = await import('vite-tsconfig-paths');

packages/vitest-config/configs/ui-config.ts

@@ -1,6 +1,6 @@
 import { loadEnv } from 'vite';
-import { defineConfig } from 'vitest/config';
 import type { Plugin, ViteUserConfig } from 'vitest/config';
+import { defineConfig } from 'vitest/config';
 
 export const uiConfig = defineConfig(async () => {
   const { default: tsconfigPaths } = await import('vite-tsconfig-paths');

packages/vitest-config/package.json

@@ -26,6 +26,7 @@
   },
   "scripts": {
     "build": "tsc --build",
+    "lint": "biome check --write",
     "collect-json-reports": "node dist/scripts/collect-json-outputs.js",
     "merge-json-reports": "nyc merge coverage/raw coverage/merged/merged-coverage.json",
     "report": "nyc report -t coverage/merged --report-dir coverage/report --reporter=html --exclude-after-remap false",
@@ -35,6 +36,7 @@
     "@buster/typescript-config": "workspace:*",
     "@vitest/coverage-v8": "^3.2.4",
     "@vitest/ui": "^3.2.4",
+    "@biomejs/biome": "2.2.5",
     "glob": "^11.0.3",
     "jsdom": "^26.1.0",
     "nyc": "^17.1.0",

packages/vitest-config/scripts/collection-json-outputs.ts

@@ -44,7 +44,6 @@ async function collectCoverageFiles() {
             await fs.copyFile(coverageFilePath, destinationFile);
           } catch (_err) {
             // File doesn't exist in this directory, skip
-            // biome-ignore lint/suspicious/noConsoleLog: <explanation>
             console.log(`No coverage.json found in ${match}`);
           }
         }
@@ -55,13 +54,11 @@ async function collectCoverageFiles() {
     const replaceDotPatterns = (str: string) => str.replace(/\.\.\//g, '');
 
     if (directoriesWithCoverage.length > 0) {
-      // biome-ignore lint/suspicious/noConsoleLog: This is a log
       console.log(
         `Found coverage.json in: ${directoriesWithCoverage.map(replaceDotPatterns).join(', ')}`
       );
     }
 
-    // biome-ignore lint/suspicious/noConsoleLog: This is a log
     console.log(`Coverage collected into: ${path.join(process.cwd())}`);
   } catch (error) {
     console.error('Error collecting coverage files:', error);

packages/web-tools/biome.json

@@ -1,7 +1,7 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.2.5/schema.json",
-  "extends": ["../../biome.json"],
+  "extends": ["../../biome2.json"],
   "files": {
-    "include": ["src/**/*"]
+    "includes": ["src/**/*"]
   }
 }

packages/web-tools/package.json

@@ -27,6 +27,7 @@
   "dependencies": {
     "@buster/typescript-config": "workspace:*",
     "@buster/vitest-config": "workspace:*",
-    "@mendable/firecrawl-js": "^1.29.1"
+    "@mendable/firecrawl-js": "^1.29.1",
+    "@biomejs/biome": "2.2.5"
   }
 }

packages/web-tools/src/index.ts

@@ -1,20 +1,17 @@
 // Main exports for the web-tools package
 export { researchCompany } from './deep-research/company-research';
-export { FirecrawlService } from './services/firecrawl';
-export { pollJobStatus } from './utils/polling';
-
 // Types
 export type {
   CompanyResearch,
-  CompanyResearchOptions,
   CompanyResearchError,
+  CompanyResearchOptions,
 } from './deep-research/types';
-
 export type {
   FirecrawlConfig,
   WebSearchOptions,
-  WebSearchResult,
   WebSearchResponse,
+  WebSearchResult,
 } from './services/firecrawl';
-
+export { FirecrawlService } from './services/firecrawl';
 export type { PollingOptions } from './utils/polling';
+export { pollJobStatus } from './utils/polling';

pnpm-lock.yaml

@@ -1395,6 +1395,9 @@ importers:
 
   packages/test-utils:
     dependencies:
+      '@biomejs/biome':
+        specifier: 2.2.5
+        version: 2.2.5
       '@buster/database':
         specifier: workspace:*
         version: link:../database
@@ -1415,6 +1418,9 @@ importers:
 
   packages/vitest-config:
     dependencies:
+      '@biomejs/biome':
+        specifier: 2.2.5
+        version: 2.2.5
       '@buster/typescript-config':
         specifier: workspace:*
         version: link:../typescript-config
@@ -1445,6 +1451,9 @@ importers:
 
   packages/web-tools:
     dependencies:
+      '@biomejs/biome':
+        specifier: 2.2.5
+        version: 2.2.5
       '@buster/typescript-config':
         specifier: workspace:*
         version: link:../typescript-config