From 328cb28261038b9f946ac968a743a7713a91a842 Mon Sep 17 00:00:00 2001 From: Nate Kelley Date: Thu, 2 Oct 2025 11:09:53 -0600 Subject: [PATCH] utc offset label update --- .../SelectAxis/SelectAxisColumnContent/EditDateFormat.tsx | 2 +- .../SelectAxisColumnContent/EditShowDataLabel.tsx | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditDateFormat.tsx b/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditDateFormat.tsx index cb80ad6e0..350b560e9 100644 --- a/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditDateFormat.tsx +++ b/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditDateFormat.tsx @@ -90,7 +90,7 @@ export const EditDateFormat: React.FC<{ showWarning={true} className="max-w-[300px]" icon={} - warningText="When UTC Offset is enabled, dates are displayed with timezone information. Use this when data is stored in different timezones or when timezone context matters. Buster tries the correct timezone and UTC Offset for each date. Note: When data is truncated (e.g., DATE_TRUNC to day/month/quarter), timezone differences are lost during truncation — the data is bucketed first, then timezone offsets are applied to the labels." + warningText="When enabled, dates show which timezone they're in. This is helpful when your data comes from different locations or when the time of day matters. Note: When data is grouped (e.g., by day, month, quarter or via a DATE_TRUNC command), timezone differences are lost during grouping — dates are grouped first, then timezone labels are added." /> diff --git a/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditShowDataLabel.tsx b/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditShowDataLabel.tsx index 9af05e122..7cefca240 100644 --- a/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditShowDataLabel.tsx +++ b/apps/web/src/controllers/MetricController/MetricViewChartController/MetricEditController/MetricStylingApp/StylingAppVisualize/SelectAxis/SelectAxisColumnContent/EditShowDataLabel.tsx @@ -4,15 +4,21 @@ import { Switch } from '@/components/ui/switch'; import { LabelAndInput } from '../../../Common/LabelAndInput'; import { WarningIcon } from '../../../Common/WarningIcon'; +const ROW_COUNT_THRESHOLD = 25; + export const EditShowDataLabel: React.FC<{ showDataLabels: Required['showDataLabels']; rowCount: number; onUpdateColumnSettingConfig: (columnSettings: Partial) => void; }> = React.memo(({ showDataLabels, rowCount, onUpdateColumnSettingConfig }) => { + const showWarning = rowCount > ROW_COUNT_THRESHOLD; return (
- + {