lint fixes

This commit is contained in:
Nate Kelley 2025-09-25 22:23:20 -06:00
parent 8ca932b60c
commit 3c11dbf291
No known key found for this signature in database
GPG Key ID: FD90372AB8D98B4F
8 changed files with 70 additions and 55 deletions

View File

@ -2107,20 +2107,20 @@ describe('aggregateAndCreateDatasets', () => {
expect(result.datasets).toHaveLength(4);
// Find sales datasets
const salesDatasets = result.datasets.filter(d => d.dataKey === 'sales');
const profitDatasets = result.datasets.filter(d => d.dataKey === 'profit');
const salesDatasets = result.datasets.filter((d) => d.dataKey === 'sales');
const profitDatasets = result.datasets.filter((d) => d.dataKey === 'profit');
expect(salesDatasets).toHaveLength(2);
expect(profitDatasets).toHaveLength(2);
// Check labels include both metric and color field
const northSalesDataset = salesDatasets.find(d => d.colors === '#0000ff');
const northSalesDataset = salesDatasets.find((d) => d.colors === '#0000ff');
expect(northSalesDataset?.label).toEqual([
{ key: 'sales', value: '' },
{ key: 'region', value: 'North' },
]);
const southProfitDataset = profitDatasets.find(d => d.colors === '#ff00ff');
const southProfitDataset = profitDatasets.find((d) => d.colors === '#ff00ff');
expect(southProfitDataset?.label).toEqual([
{ key: 'profit', value: '' },
{ key: 'region', value: 'South' },
@ -2161,7 +2161,7 @@ describe('aggregateAndCreateDatasets', () => {
// Check that labels include product category AND color field
const northProductADataset = result.datasets.find(
d => d.colors === '#aabbcc' && d.label.some(l => l.key === 'product' && l.value === 'A')
(d) => d.colors === '#aabbcc' && d.label.some((l) => l.key === 'product' && l.value === 'A')
);
expect(northProductADataset).toBeDefined();
@ -2172,7 +2172,7 @@ describe('aggregateAndCreateDatasets', () => {
expect(northProductADataset?.data).toEqual([100, 120]);
const southProductADataset = result.datasets.find(
d => d.colors === '#ddeeff' && d.label.some(l => l.key === 'product' && l.value === 'A')
(d) => d.colors === '#ddeeff' && d.label.some((l) => l.key === 'product' && l.value === 'A')
);
expect(southProductADataset).toBeDefined();
@ -2210,7 +2210,7 @@ describe('aggregateAndCreateDatasets', () => {
expect(result.datasets).toHaveLength(1);
// Dataset A should have real data
const datasetA = result.datasets.find(d => d.colors === '#ff0000');
const datasetA = result.datasets.find((d) => d.colors === '#ff0000');
expect(datasetA?.data).toEqual([100, 120]);
expect(datasetA?.label).toEqual([{ key: 'category', value: 'A' }]);

View File

@ -83,10 +83,14 @@ describe('Analyst Agent Instructions', () => {
expect(result).toContain('MANDATORY SQL NAMING CONVENTIONS');
// Ensure table references require full qualification
expect(result).toContain('All Table References: MUST be fully qualified: `DATABASE_NAME.SCHEMA_NAME.TABLE_NAME`');
expect(result).toContain(
'All Table References: MUST be fully qualified: `DATABASE_NAME.SCHEMA_NAME.TABLE_NAME`'
);
// Ensure column references use table aliases (not full qualifiers)
expect(result).toContain('All Column References: MUST be qualified with their table alias (e.g., `c.customerid`)');
expect(result).toContain(
'All Column References: MUST be qualified with their table alias (e.g., `c.customerid`)'
);
// Ensure examples show table alias usage without full qualification
expect(result).toContain('c.customerid');

View File

@ -151,16 +151,23 @@ describe('Think and Prep Agent Instructions', () => {
['investigation', 'investigation'],
])('SQL naming conventions in %s mode', (modeName, mode) => {
it(`should contain mandatory SQL naming conventions in ${modeName} mode`, () => {
const result = getThinkAndPrepAgentSystemPrompt('Test guidance', mode as 'standard' | 'investigation');
const result = getThinkAndPrepAgentSystemPrompt(
'Test guidance',
mode as 'standard' | 'investigation'
);
// Check for MANDATORY SQL NAMING CONVENTIONS section
expect(result).toContain('MANDATORY SQL NAMING CONVENTIONS');
// Ensure table references require full qualification
expect(result).toContain('All Table References: MUST be fully qualified: `DATABASE_NAME.SCHEMA_NAME.TABLE_NAME`');
expect(result).toContain(
'All Table References: MUST be fully qualified: `DATABASE_NAME.SCHEMA_NAME.TABLE_NAME`'
);
// Ensure column references use table aliases (not full qualifiers)
expect(result).toContain('All Column References: MUST be qualified with their table alias (e.g., `c.customerid`)');
expect(result).toContain(
'All Column References: MUST be qualified with their table alias (e.g., `c.customerid`)'
);
// Ensure examples show table alias usage without full qualification
expect(result).toContain('c.customerid');
@ -172,7 +179,10 @@ describe('Think and Prep Agent Instructions', () => {
});
it(`should use column names qualified with table aliases in ${modeName} mode`, () => {
const result = getThinkAndPrepAgentSystemPrompt('Test guidance', mode as 'standard' | 'investigation');
const result = getThinkAndPrepAgentSystemPrompt(
'Test guidance',
mode as 'standard' | 'investigation'
);
// Check for the updated description
expect(result).toContain('Use column names qualified with table aliases');

View File

@ -14,7 +14,7 @@ export const DEFAULT_ANTHROPIC_OPTIONS = {
additionalModelRequestFields: {
anthropic_beta: ['fine-grained-tool-streaming-2025-05-14'],
},
}
},
};
export const DEFAULT_OPENAI_OPTIONS = {

View File

@ -32,20 +32,21 @@ type VersionHistoryEntry = {
type VersionHistory = Record<string, VersionHistoryEntry>;
// Simple in-memory queue for each reportId
const updateQueues = new Map<string, Promise<{
const updateQueues = new Map<
string,
Promise<{
id: string;
name: string;
content: string;
versionHistory: VersionHistory | null;
}>>();
}>
>();
/**
* Internal function that performs the actual update logic.
* This is separated so it can be queued.
*/
async function performUpdate(
params: BatchUpdateReportInput
): Promise<{
async function performUpdate(params: BatchUpdateReportInput): Promise<{
id: string;
name: string;
content: string;
@ -120,11 +121,13 @@ export const batchUpdateReport = async (
const { reportId } = params;
// Get the current promise for this reportId, or use a resolved promise as the starting point
const currentQueue = updateQueues.get(reportId) ?? Promise.resolve({
const currentQueue =
updateQueues.get(reportId) ??
Promise.resolve({
id: '',
name: '',
content: '',
versionHistory: null
versionHistory: null,
});
// Chain the new update to run after the current queue completes

View File

@ -32,13 +32,11 @@ describe('DEFAULT_CHART_CONFIG', () => {
category: [],
size: [],
tooltip: null,
colorBy: null,
});
expect(config.pieChartAxis).toEqual({
x: [],
y: [],
tooltip: null,
colorBy: null,
});
// Verify the config is a complete object with all required properties