From 4807e092bb8b2e3ca8a6a190f35539bce288d2a5 Mon Sep 17 00:00:00 2001
From: Nate Kelley <nate@buster.so>
Date: Mon, 29 Sep 2025 11:04:22 -0600
Subject: [PATCH] update mention input for

---
 .../BusterInput/BusterInput.stories.tsx       |  3 +-
 .../ui/inputs/BusterInput/BusterInput.tsx     |  2 +
 .../inputs/BusterInput/BusterInput.types.ts   |  3 +-
 .../BusterInput/BusterMentionsInput.tsx       |  3 +
 .../ui/inputs/MentionInput/MentionInput.tsx   | 75 ++++---------------
 .../inputs/MentionInput/MentionInput.types.ts |  1 +
 .../MentionInput/SubmitEnterExtension.ts      | 29 +++++++
 .../MentionInput/update-transformers.ts       | 48 ++++++++++++
 8 files changed, 102 insertions(+), 62 deletions(-)
 create mode 100644 apps/web/src/components/ui/inputs/MentionInput/SubmitEnterExtension.ts
 create mode 100644 apps/web/src/components/ui/inputs/MentionInput/update-transformers.ts

diff --git a/apps/web/src/components/ui/inputs/BusterInput/BusterInput.stories.tsx b/apps/web/src/components/ui/inputs/BusterInput/BusterInput.stories.tsx
index b5bc17f93..bd11e4143 100644
--- a/apps/web/src/components/ui/inputs/BusterInput/BusterInput.stories.tsx
+++ b/apps/web/src/components/ui/inputs/BusterInput/BusterInput.stories.tsx
@@ -1,11 +1,11 @@
 import type { Meta, StoryObj } from '@storybook/react-vite';
+import { fn } from 'storybook/test';
 import { BusterInput } from './BusterInput';
 import type { BusterInputProps } from './BusterInput.types';
 
 const meta: Meta<typeof BusterInput> = {
   title: 'UI/Inputs/BusterInput',
   component: BusterInput,
-  tags: ['autodocs'],
   decorators: [
     (Story) => (
       <div style={{ width: '300px', minHeight: '500px' }}>
@@ -78,5 +78,6 @@ export const Default: Story = {
     value: 'Sample text value',
     suggestionItems: items,
     mentions,
+    onSubmit: fn(),
   },
 };
diff --git a/apps/web/src/components/ui/inputs/BusterInput/BusterInput.tsx b/apps/web/src/components/ui/inputs/BusterInput/BusterInput.tsx
index ee7367214..b057d8f72 100644
--- a/apps/web/src/components/ui/inputs/BusterInput/BusterInput.tsx
+++ b/apps/web/src/components/ui/inputs/BusterInput/BusterInput.tsx
@@ -15,6 +15,7 @@ export const BusterInput = ({
   emptyComponent,
   submitting,
   onSubmit,
+  onPressEnter,
   disabled: disabledGlobal = false,
   onStop,
   sendIcon,
@@ -105,6 +106,7 @@ export const BusterInput = ({
           shouldFilter={shouldFilter}
           filter={filter}
           onMentionItemClick={onMentionItemClick}
+          onPressEnter={onPressEnter || onSubmit}
         />
       </BusterInputContainer>
       <BusterInputList show={showSuggestionList}>
diff --git a/apps/web/src/components/ui/inputs/BusterInput/BusterInput.types.ts b/apps/web/src/components/ui/inputs/BusterInput/BusterInput.types.ts
index 4cbcb54cb..83671cb06 100644
--- a/apps/web/src/components/ui/inputs/BusterInput/BusterInput.types.ts
+++ b/apps/web/src/components/ui/inputs/BusterInput/BusterInput.types.ts
@@ -1,7 +1,7 @@
 import type { Command } from 'cmdk';
 import type React from 'react';
 import type { MentionSuggestionExtension } from '../MentionInput';
-import type { MentionTriggerItem } from '../MentionInput/MentionInput.types';
+import type { MentionInputProps, MentionTriggerItem } from '../MentionInput/MentionInput.types';
 
 /**
  * @description Override the addValueToInput and closeOnSelect props for the item based on the group props
@@ -59,6 +59,7 @@ export type BusterInputProps<T = string> = {
   disabled?: boolean;
   readOnly?: boolean;
   onSubmit: (value: string) => void;
+  onPressEnter: MentionInputProps['onPressEnter'];
   onStop: () => void;
   variant?: 'default';
   autoFocus?: boolean;
diff --git a/apps/web/src/components/ui/inputs/BusterInput/BusterMentionsInput.tsx b/apps/web/src/components/ui/inputs/BusterInput/BusterMentionsInput.tsx
index 7a60485e1..6ac21ed5e 100644
--- a/apps/web/src/components/ui/inputs/BusterInput/BusterMentionsInput.tsx
+++ b/apps/web/src/components/ui/inputs/BusterInput/BusterMentionsInput.tsx
@@ -15,6 +15,7 @@ export type BusterMentionsInputProps = Pick<
   | 'onMentionItemClick'
 > & {
   onChange: MentionInputProps['onChange'];
+  onPressEnter: MentionInputProps['onPressEnter'];
   className?: string;
   style?: React.CSSProperties;
   autoFocus?: boolean;
@@ -35,7 +36,9 @@ export const BusterMentionsInput = ({
       <Command.Input
         value={value}
         autoFocus={false}
+        //  className="sr-only hidden h-0 border-0 p-0"
         className="absolute -top-5 left-0 w-full outline-1 outline-amber-200 pointer-events-none"
+        aria-hidden="true"
       />
     </React.Fragment>
   );
diff --git a/apps/web/src/components/ui/inputs/MentionInput/MentionInput.tsx b/apps/web/src/components/ui/inputs/MentionInput/MentionInput.tsx
index e405cb6f5..aaacf715f 100644
--- a/apps/web/src/components/ui/inputs/MentionInput/MentionInput.tsx
+++ b/apps/web/src/components/ui/inputs/MentionInput/MentionInput.tsx
@@ -2,23 +2,13 @@ import { ClientOnly } from '@tanstack/react-router';
 import Document from '@tiptap/extension-document';
 import Paragraph from '@tiptap/extension-paragraph';
 import Text from '@tiptap/extension-text';
-import {
-  type Editor,
-  EditorContent,
-  EditorContext,
-  type NodeType,
-  type TextType,
-  useEditor,
-} from '@tiptap/react';
+import { EditorContent, EditorContext, useEditor } from '@tiptap/react';
 import { useMemo } from 'react';
 import { cn } from '@/lib/utils';
 import { MentionExtension } from './MentionExtension';
-import type {
-  MentionArrayItem,
-  MentionInputProps,
-  MentionSuggestionExtension,
-} from './MentionInput.types';
-import type { MentionPillAttributes } from './MentionPill';
+import type { MentionInputProps, MentionSuggestionExtension } from './MentionInput.types';
+import { SubmitOnEnter } from './SubmitEnterExtension';
+import { onUpdateTransformer } from './update-transformers';
 
 export const MentionInput = ({
   mentions,
@@ -31,6 +21,7 @@ export const MentionInput = ({
   className,
   readOnly,
   disabled,
+  onPressEnter,
 }: MentionInputProps) => {
   const mentionsByTrigger = useMemo(() => {
     return mentions.reduce(
@@ -45,7 +36,16 @@ export const MentionInput = ({
   }, [mentions]);
 
   const editor = useEditor({
-    extensions: [Document, Paragraph, Text, MentionExtension(mentions)],
+    extensions: [
+      Document,
+      Paragraph,
+      Text,
+      MentionExtension(mentions),
+      SubmitOnEnter({
+        mentionsByTrigger,
+        onPressEnter,
+      }),
+    ],
     content: defaultValue,
     autofocus: autoFocus,
     editable: !disabled && !readOnly,
@@ -75,48 +75,3 @@ export const MentionInput = ({
     </ClientOnly>
   );
 };
-
-const onUpdateTransformer = ({
-  editor,
-  mentionsByTrigger,
-}: {
-  editor: Editor;
-  mentionsByTrigger: Record<string, MentionSuggestionExtension>;
-}) => {
-  const editorText = editor.getText();
-  const editorJson = editor.getJSON();
-  const transformedJson: MentionArrayItem[] = editorJson.content.reduce<MentionArrayItem[]>(
-    (acc, item) => {
-      if (item.type === 'paragraph') {
-        item.content?.forEach((item) => {
-          if (item.type === 'text') {
-            const _item = item as TextType;
-            acc.push({ type: 'text', text: _item.text });
-          } else if (item.type === 'mention') {
-            const _item = item as NodeType<'mention', MentionPillAttributes>;
-            acc.push({ type: 'mention', attrs: _item.attrs });
-          }
-        });
-      }
-      return acc;
-    },
-    []
-  );
-  const transformedValue = transformedJson.reduce((acc, item) => {
-    if (item.type === 'text') {
-      return acc + item.text;
-    }
-    if (item.type === 'mention') {
-      const onChangeTransform = mentionsByTrigger[item.attrs.trigger]?.onChangeTransform;
-      if (onChangeTransform) return acc + onChangeTransform(item.attrs);
-      return acc + item.attrs.label;
-    }
-    return acc;
-  }, '');
-
-  return {
-    transformedValue,
-    transformedJson,
-    editorText,
-  };
-};
diff --git a/apps/web/src/components/ui/inputs/MentionInput/MentionInput.types.ts b/apps/web/src/components/ui/inputs/MentionInput/MentionInput.types.ts
index 8720dfe6d..29d9f89b9 100644
--- a/apps/web/src/components/ui/inputs/MentionInput/MentionInput.types.ts
+++ b/apps/web/src/components/ui/inputs/MentionInput/MentionInput.types.ts
@@ -90,6 +90,7 @@ export type MentionOnChangeParams = (
 export type MentionInputProps = {
   mentions: MentionSuggestionExtension[];
   onChange: MentionOnChangeParams;
+  onPressEnter?: MentionOnChangeParams;
   onFocus?: (v: EditorEvents['focus']) => void;
   onBlur?: (v: EditorEvents['blur']) => void;
   defaultValue?: string;
diff --git a/apps/web/src/components/ui/inputs/MentionInput/SubmitEnterExtension.ts b/apps/web/src/components/ui/inputs/MentionInput/SubmitEnterExtension.ts
new file mode 100644
index 000000000..66019ad47
--- /dev/null
+++ b/apps/web/src/components/ui/inputs/MentionInput/SubmitEnterExtension.ts
@@ -0,0 +1,29 @@
+import { Extension } from '@tiptap/core';
+import type { MentionInputProps, MentionSuggestionExtension } from './MentionInput.types';
+import { onUpdateTransformer } from './update-transformers';
+
+export const SubmitOnEnter = ({
+  onPressEnter,
+  mentionsByTrigger,
+}: {
+  onPressEnter?: MentionInputProps['onPressEnter'];
+  mentionsByTrigger: Record<string, MentionSuggestionExtension>;
+}) =>
+  Extension.create({
+    addKeyboardShortcuts() {
+      return {
+        Enter: ({ editor }) => {
+          console.log('Enter', onPressEnter);
+          if (onPressEnter) {
+            const { transformedValue, transformedJson, editorText } = onUpdateTransformer({
+              editor,
+              mentionsByTrigger,
+            });
+            onPressEnter?.(transformedValue, transformedJson, editorText);
+          }
+          return !!onPressEnter;
+        },
+        'Shift-Enter': () => this.editor.commands.newlineInCode(), // or insert a break
+      };
+    },
+  });
diff --git a/apps/web/src/components/ui/inputs/MentionInput/update-transformers.ts b/apps/web/src/components/ui/inputs/MentionInput/update-transformers.ts
new file mode 100644
index 000000000..06c5e23b3
--- /dev/null
+++ b/apps/web/src/components/ui/inputs/MentionInput/update-transformers.ts
@@ -0,0 +1,48 @@
+import type { Editor, NodeType, TextType } from '@tiptap/react';
+import type { MentionArrayItem, MentionSuggestionExtension } from './MentionInput.types';
+import type { MentionPillAttributes } from './MentionPill';
+
+export const onUpdateTransformer = ({
+  editor,
+  mentionsByTrigger,
+}: {
+  editor: Editor;
+  mentionsByTrigger: Record<string, MentionSuggestionExtension>;
+}) => {
+  const editorText = editor.getText();
+  const editorJson = editor.getJSON();
+  const transformedJson: MentionArrayItem[] = editorJson.content.reduce<MentionArrayItem[]>(
+    (acc, item) => {
+      if (item.type === 'paragraph') {
+        item.content?.forEach((item) => {
+          if (item.type === 'text') {
+            const _item = item as TextType;
+            acc.push({ type: 'text', text: _item.text });
+          } else if (item.type === 'mention') {
+            const _item = item as NodeType<'mention', MentionPillAttributes>;
+            acc.push({ type: 'mention', attrs: _item.attrs });
+          }
+        });
+      }
+      return acc;
+    },
+    []
+  );
+  const transformedValue = transformedJson.reduce((acc, item) => {
+    if (item.type === 'text') {
+      return acc + item.text;
+    }
+    if (item.type === 'mention') {
+      const onChangeTransform = mentionsByTrigger[item.attrs.trigger]?.onChangeTransform;
+      if (onChangeTransform) return acc + onChangeTransform(item.attrs);
+      return acc + item.attrs.label;
+    }
+    return acc;
+  }, '');
+
+  return {
+    transformedValue,
+    transformedJson,
+    editorText,
+  };
+};