Ling0925
/
buster
mirror of https://github.com/buster-so/buster.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

read only bug fix

This commit is contained in:
Nate Kelley 2025-09-27 19:52:41 -06:00
parent 00caf1fe0a
commit 5f8991c7fe
No known key found for this signature in database
GPG Key ID: FD90372AB8D98B4F
2 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/web/src/components/ui/report/ReportEditor.tsx
View File

@ -1,6 +1,6 @@
import type { AnyPluginConfig, Value } from 'platejs';
import { Plate, type TPlateEditor } from 'platejs/react';
import React, { useEffect, useImperativeHandle, useRef } from 'react';
import React, { useEffect, useImperativeHandle, useRef, useState } from 'react';
import { ScrollToBottomButton } from '@/components/features/buttons/ScrollToBottomButton';
import { useAutoScroll } from '@/hooks/useAutoScroll';
import { useDebounceFn } from '@/hooks/useDebounce';
@ -140,7 +140,6 @@ export const ReportEditor = React.memo(
<Plate editor={editor} onValueChange={onValueChangeDebounced}>
<EditorContainer
variant={variant}
readOnly={readOnly}
className={cn('editor-container relative', containerClassName)}
>
{preEditorChildren}
@ -149,7 +148,7 @@ export const ReportEditor = React.memo(
style={style}
placeholder={placeholder}
className={cn('editor', className)}
readOnly={readOnly || isStreaming}
readOnly={readOnly} //do not have streaming here, it causes scrolling issue when toggling
autoFocus
/>
</ThemeWrapper>

20
apps/web/src/layouts/ChatLayout/ChatLayoutContext/useAutoRedirectStreaming.test.ts
View File

@ -6,6 +6,8 @@ import { useAutoRedirectStreaming } from './useAutoRedirectStreaming';
// Mock all the dependencies
vi.mock('@tanstack/react-router', () => ({
useNavigate: vi.fn(),
useLocation: vi.fn(),
useRouter: vi.fn(),
}));
vi.mock('@/api/buster_rest/chats', () => ({
@ -27,6 +29,10 @@ vi.mock('@/context/Chats/useGetChatMessage', () => ({
useGetChatMessageLastReasoningMessageId: vi.fn(),
}));
vi.mock('@/context/Routes/useRouteBuilder', () => ({
useBuildLocation: vi.fn(),
}));
vi.mock('@/hooks/useWindowFocus', () => ({
useWindowFocus: vi.fn(),
}));
@ -36,7 +42,7 @@ vi.mock('@/lib/assets/assetParamsToRoute', () => ({
}));
// Import the mocked functions to use in tests
import { useNavigate } from '@tanstack/react-router';
import { useLocation, useNavigate } from '@tanstack/react-router';
import { useGetChatMessageMemoized } from '@/api/buster_rest/chats';
import { useIsVersionChanged } from '@/context/AppVersion/useAppVersion';
import { useHasLoadedChat } from '@/context/Chats/useGetChat';
@ -46,6 +52,7 @@ import {
useGetChatMessageIsFinishedReasoning,
useGetChatMessageLastReasoningMessageId,
} from '@/context/Chats/useGetChatMessage';
import { useBuildLocation } from '@/context/Routes/useRouteBuilder';
import { assetParamsToRoute } from '@/lib/assets/assetParamsToRoute';
describe('useAutoRedirectStreaming', () => {
@ -69,6 +76,7 @@ describe('useAutoRedirectStreaming', () => {
};
let mockNavigateFn: ReturnType<typeof vi.fn>;
let mockBuildLocationFn: ReturnType<typeof vi.fn>;
beforeEach(() => {
vi.clearAllMocks();
@ -77,6 +85,16 @@ describe('useAutoRedirectStreaming', () => {
mockNavigateFn = vi.fn();
vi.mocked(useNavigate).mockReturnValue(mockNavigateFn);
// Setup location mocks
vi.mocked(useLocation).mockReturnValue({
pathname: '/current/path',
} as any);
mockBuildLocationFn = vi.fn().mockReturnValue({
pathname: '/different/path', // Different from current location to trigger navigation
});
vi.mocked(useBuildLocation).mockReturnValue(mockBuildLocationFn);
// Set default mock implementations
vi.mocked(useHasLoadedChat).mockReturnValue(true);
vi.mocked(useGetChatMessageCompleted).mockReturnValue(false);