From 69eb14c836e15c94d9110b700b0ff057dad87259 Mon Sep 17 00:00:00 2001
From: Nate Kelley <nate@buster.so>
Date: Thu, 7 Aug 2025 16:44:49 -0600
Subject: [PATCH] Update report editor to the ui

---
 .../web/src/components/ui/report/ReportEditor.tsx | 14 +++++++++++++-
 .../ReportPageController/ReportPageController.tsx | 15 ++++++++++++---
 2 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/apps/web/src/components/ui/report/ReportEditor.tsx b/apps/web/src/components/ui/report/ReportEditor.tsx
index dfa0fa570..024247aa0 100644
--- a/apps/web/src/components/ui/report/ReportEditor.tsx
+++ b/apps/web/src/components/ui/report/ReportEditor.tsx
@@ -54,7 +54,15 @@ export const ReportEditor = React.memo(
       const editor = useReportEditor({ value, disabled, useFixedToolbarKit, onReady });
 
       const onReset = useMemoizedFn(() => {
-        editor?.tf.reset();
+        if (!editor) {
+          console.warn('Editor not yet initialized');
+          return;
+        }
+        if (readOnly) {
+          console.warn('Editor is read only');
+          return;
+        }
+        editor.tf.reset();
       });
 
       // Optionally expose the editor instance to the parent via ref
@@ -62,6 +70,10 @@ export const ReportEditor = React.memo(
 
       const onValueChangePreflight = useMemoizedFn(
         ({ value, editor }: { value: Value; editor: TPlateEditor<Value, AnyPluginConfig> }) => {
+          if (readOnly) {
+            console.warn('Editor is read only');
+            return;
+          }
           onValueChange?.(cleanValueToReportElements(value));
         }
       );
diff --git a/apps/web/src/controllers/ReportPageControllers/ReportPageController/ReportPageController.tsx b/apps/web/src/controllers/ReportPageControllers/ReportPageController/ReportPageController.tsx
index 2610e3040..f8931d8d0 100644
--- a/apps/web/src/controllers/ReportPageControllers/ReportPageController/ReportPageController.tsx
+++ b/apps/web/src/controllers/ReportPageControllers/ReportPageController/ReportPageController.tsx
@@ -7,7 +7,8 @@ import { ReportPageHeader } from './ReportPageHeader';
 import { useMemoizedFn } from '@/hooks/useMemoizedFn';
 import { useDebounceFn } from '@/hooks/useDebounce';
 import type { ReportElements } from '@buster/server-shared/reports';
-import DynamicReportEditor from '@/components/ui/report/DynamicReportEditor';
+//import DynamicReportEditor from '@/components/ui/report/DynamicReportEditor';
+import { ReportEditor } from '@/components/ui/report/ReportEditor';
 
 export const ReportPageController: React.FC<{
   reportId: string;
@@ -22,12 +23,20 @@ export const ReportPageController: React.FC<{
   const { mutate: updateReport } = useUpdateReport();
 
   const onChangeName = useMemoizedFn((name: string) => {
+    if (!report) {
+      console.warn('Report not yet fetched');
+      return;
+    }
     updateReport({ reportId, name });
   });
 
   const { run: debouncedUpdateReport } = useDebounceFn(updateReport, { wait: 650 });
 
   const onChangeContent = useMemoizedFn((content: ReportElements) => {
+    if (!report) {
+      console.warn('Report not yet fetched');
+      return;
+    }
     debouncedUpdateReport({ reportId, content });
   });
 
@@ -39,11 +48,11 @@ export const ReportPageController: React.FC<{
         onChangeName={onChangeName}
       />
 
-      <DynamicReportEditor
+      <ReportEditor
         //   ref={editor}
         value={content}
         onValueChange={onChangeContent}
-        readOnly={readOnly}
+        readOnly={readOnly || !report}
         className="px-0!"
       />
     </div>