Ling0925
/
buster
mirror of https://github.com/buster-so/buster.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not dynamically import confirm modal

This commit is contained in:
Nate Kelley 2025-09-25 08:03:12 -06:00
parent abc8b7ed8a
commit 70e0e0c86d
No known key found for this signature in database
GPG Key ID: FD90372AB8D98B4F
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/web/src/components/ui/modal/ModalBase.tsx
View File

@ -1,6 +1,6 @@
import * as DialogPrimitive from '@radix-ui/react-dialog';
import * as React from 'react';
import { Xmark } from '@/components/ui/icons';
import Xmark from '@/components/ui/icons/NucleoIconOutlined/xmark';
import { cn } from '@/lib/utils';
import { Button } from '../buttons/Button';

11
apps/web/src/context/BusterNotifications/BusterNotifications.tsx
View File

@ -1,17 +1,14 @@
import type React from 'react';
import type { PropsWithChildren } from 'react';
import { lazy, Suspense, useCallback } from 'react';
import { Suspense, useCallback } from 'react';
import { type ExternalToast, toast } from 'sonner';
import { createContext, useContextSelector } from 'use-context-selector';
import { ConfirmModal } from '@/components/ui/modal/ConfirmModal';
import { Toaster } from '@/components/ui/toaster/Toaster';
import { useConfirmModalContext } from './useConfirmModal';
export type NotificationType = 'success' | 'info' | 'warning' | 'error';
const ConfirmModal = lazy(() =>
import('@/components/ui/modal/ConfirmModal').then((mod) => ({ default: mod.ConfirmModal }))
);
export type NotificationProps = {
type?: NotificationType;
title?: string;
@ -136,9 +133,7 @@ export const BusterNotificationsProvider: React.FC<PropsWithChildren> = ({ child
<BusterNotifications.Provider value={{ ...value, openConfirmModal }}>
{children}
<Toaster />
<Suspense fallback={<span className="hidden">...</span>}>
<ConfirmModal {...confirmModalProps} />
</Suspense>
<ConfirmModal {...confirmModalProps} />
</BusterNotifications.Provider>
);
};