favorites on list endpoint

web/src/components/ui/dropdown/Dropdown.tsx

@@ -110,7 +110,7 @@ export const DropdownBase = <T,>({
         <span className="dropdown-trigger">{children}</span>
       </DropdownMenuTrigger>
       <DropdownMenuContent
-        className={cn('max-w-72 min-w-44', className)}
+        className={cn('max-w-72 min-w-48', className)}
         align={align}
         side={side}
         sideOffset={sideOffset}>

web/src/components/ui/tooltip/TooltipBase.tsx

@@ -14,18 +14,20 @@ const TooltipContent = React.forwardRef<
   React.ElementRef<typeof TooltipPrimitive.Content>,
   React.ComponentPropsWithoutRef<typeof TooltipPrimitive.Content>
 >(({ className, sideOffset = 4, ...props }, ref) => (
-  <TooltipPrimitive.Content
-    ref={ref}
-    sideOffset={sideOffset}
-    className={cn(
-      'bg-popover text-popover-foreground',
-      'rounded border py-1.5 pr-0.5 pl-1.5',
-      'text-sm shadow',
-      'animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 z-50 overflow-hidden',
-      className
-    )}
-    {...props}
-  />
+  <TooltipPrimitive.Portal>
+    <TooltipPrimitive.Content
+      ref={ref}
+      sideOffset={sideOffset}
+      className={cn(
+        'bg-popover text-popover-foreground',
+        'rounded border py-1.5 pr-0.5 pl-1.5',
+        'text-sm shadow',
+        'animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 z-50 overflow-hidden',
+        className
+      )}
+      {...props}
+    />
+  </TooltipPrimitive.Portal>
 ));
 TooltipContent.displayName = TooltipPrimitive.Content.displayName;
 

web/src/controllers/CollectionListController/CollectionsListContent.tsx

@@ -13,8 +13,10 @@ import {
 } from '@/components/ui/list';
 import { useMemoizedFn } from '@/hooks';
 import { NewCollectionModal } from '@/components/features/modal/NewCollectionModal';
-import { BusterCollectionListItem } from '@/api/asset_interfaces';
+import { BusterCollectionListItem, ShareAssetType } from '@/api/asset_interfaces';
 import { CollectionListSelectedPopup } from './CollectionListSelectedPopup';
+import { Text } from '@/components/ui/typography';
+import { FavoriteStar } from '@/components/features/list';
 
 export const CollectionsListContent: React.FC<{
   openNewCollectionModal: boolean;
@@ -54,17 +56,28 @@ export const CollectionsListContent: React.FC<{
 CollectionsListContent.displayName = 'CollectionsListContent';
 
 const columns: BusterListColumn[] = [
-  { dataIndex: 'title', title: 'Title' },
   {
-    dataIndex: 'createdAt',
-    title: 'Created at',
-    width: 145,
-    render: (v) => formatDate({ date: v, format: 'lll' })
+    dataIndex: 'name',
+    title: 'Title',
+    render: (v, { id, ...rest }: BusterCollectionListItem) => {
+      return (
+        <div className="mr-2 flex items-center space-x-1.5">
+          <Text truncate>{v}</Text>
+          <FavoriteStar
+            id={id}
+            type={ShareAssetType.COLLECTION}
+            iconStyle="tertiary"
+            title={v}
+            className="opacity-0 group-hover:opacity-100"
+          />
+        </div>
+      );
+    }
   },
   {
-    dataIndex: 'lastEdited',
+    dataIndex: 'last_edited',
     title: 'Last edited',
-    width: 145,
+    width: 150,
     render: (v) => formatDate({ date: v, format: 'lll' })
   },
   {
@@ -98,13 +111,7 @@ const CollectionList: React.FC<{
           route: BusterRoutes.APP_COLLECTIONS_ID,
           collectionId: collection.id
         }),
-        data: {
-          title: collection.name,
-          lastEdited: collection.last_edited,
-          createdAt: collection.created_at,
-          owner: collection.owner,
-          sharing: collection.sharing
-        }
+        data: collection
       };
     });
   }, [collectionsList]);

web/src/controllers/DashboardListController/DashboardListContent.tsx

@@ -16,14 +16,28 @@ import type { BusterDashboardListItem } from '@/api/asset_interfaces';
 import { getShareStatus } from '@/components/features/metrics/StatusBadgeIndicator/helpers';
 import { useCreateDashboard } from '@/api/buster_rest/dashboards';
 import { useAppLayoutContextSelector } from '@/context/BusterAppLayout';
+import { FavoriteStar } from '@/components/features/list';
+import { ShareAssetType } from '@/api/asset_interfaces';
+import { Text } from '@/components/ui/typography';
 
 const columns: BusterListColumn[] = [
   {
     dataIndex: 'name',
     title: 'Title',
-    render: (data) => {
-      if (data) return data;
-      return 'New Dashboard';
+    render: (data, { id }) => {
+      const name = data || 'New Dashboard';
+      return (
+        <div className="mr-2 flex items-center space-x-1.5">
+          <Text truncate>{name}</Text>
+          <FavoriteStar
+            id={id}
+            type={ShareAssetType.DASHBOARD}
+            iconStyle="tertiary"
+            title={name}
+            className="opacity-0 group-hover:opacity-100"
+          />
+        </div>
+      );
     }
   },
   {

web/src/controllers/MetricListContainer/MetricItemsContainer.tsx

@@ -158,20 +158,18 @@ const TitleCell = React.memo<{ title: string; status: VerificationStatus; metric
     });
 
     return (
-      <div className="flex w-full items-center space-x-2">
+      <div className="mr-2 flex w-full items-center space-x-2">
         <div className="flex items-center justify-center">
           <StatusBadgeIndicator status={status} />
         </div>
         <Text truncate>{title}</Text>
-        <div className="mr-2 flex items-center" onClick={onFavoriteDivClick}>
-          <FavoriteStar
-            id={metricId}
-            type={ShareAssetType.METRIC}
-            iconStyle="tertiary"
-            title={title}
-            className="opacity-0 group-hover:opacity-100"
-          />
-        </div>
+        <FavoriteStar
+          id={metricId}
+          type={ShareAssetType.METRIC}
+          iconStyle="tertiary"
+          title={title}
+          className="opacity-0 group-hover:opacity-100"
+        />
       </div>
     );
   }

web/src/layouts/ChatLayout/FileContainer/FileContainerHeader/DashboardContainerHeaderButtons/DashboardThreeDotMenu.tsx

@@ -33,6 +33,7 @@ import { ShareMenuContent } from '@/components/features/ShareMenu/ShareMenuConte
 import { DASHBOARD_TITLE_INPUT_ID } from '@/controllers/DashboardController/DashboardViewDashboardController/DashboardEditTitle';
 import { canEdit, canFilter, getIsEffectiveOwner } from '@/lib/share';
 import { getShareAssetConfig } from '@/components/features/ShareMenu/helpers';
+import { useDashboardContentStore } from '@/context/Dashboards';
 
 export const DashboardThreeDotMenu = React.memo(({ dashboardId }: { dashboardId: string }) => {
   const versionHistoryItems = useVersionHistorySelectMenu({ dashboardId });
@@ -245,13 +246,16 @@ export const useShareMenuSelectMenu = ({ dashboardId }: { dashboardId: string })
 };
 
 const useAddContentToDashboardSelectMenu = () => {
+  const onOpenAddContentModal = useDashboardContentStore((x) => x.onOpenAddContentModal);
+
   return useMemo(
     () => ({
       label: 'Add content',
       value: 'add-content',
-      icon: <Plus />
+      icon: <Plus />,
+      onClick: onOpenAddContentModal
     }),
-    []
+    [onOpenAddContentModal]
   );
 };