Ling0925
/
buster
mirror of https://github.com/buster-so/buster.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix BUS-1891: Apply consistent 400px max height to all metric types 

- Remove special case for tables in cardClass logic
- Apply max-h-[400px] universally instead of max-h-[600px]
- Tables will now naturally size to content up to 400px limit
- Maintains virtualization performance within height constraint

Co-Authored-By: nate@buster.so <nate@buster.so>
This commit is contained in:
Devin AI 2025-09-24 13:58:32 +00:00
parent 86aa056291
commit 920520a2f6
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/web/src/components/features/metrics/MetricChartCard/MetricChartCard.tsx
View File

@ -152,10 +152,9 @@ const MetricViewChartCardContainer = React.forwardRef<
MetricViewChartCardContainerProps
>(({ children, loadingData, hasData, errorData, isTable, className }, ref) => {
const cardClass = React.useMemo(() => {
if (loadingData || errorData || !hasData) return 'h-full max-h-[600px]';
if (isTable) return '';
return 'h-full max-h-[600px]';
}, [isTable, loadingData, hasData, errorData]);
if (loadingData || errorData || !hasData) return 'h-full max-h-[400px]';
return 'h-full max-h-[400px]';
}, [loadingData, hasData, errorData]);
return (
<MetricViewChartProvider>