diff --git a/apps/server/src/api/v2/dashboards/[id]/GET.ts b/apps/server/src/api/v2/dashboards/[id]/GET.ts index 199cfa747..0669d5c19 100644 --- a/apps/server/src/api/v2/dashboards/[id]/GET.ts +++ b/apps/server/src/api/v2/dashboards/[id]/GET.ts @@ -270,7 +270,7 @@ async function getMetricsFromDashboardMetricIds( // Process all metrics concurrently const promises = metricIds.map(async (metricId) => { const processedData = await fetchAndProcessMetricData(metricId, user, { - publicAccessPreviouslyVerfified: true, // Access is inherited from dashboard access at a minimum + publicAccessPreviouslyVerified: true, // Access is inherited from dashboard access at a minimum }); // Build the metric response diff --git a/apps/server/src/api/v2/metric_files/[id]/GET.ts b/apps/server/src/api/v2/metric_files/[id]/GET.ts index 91b53f945..79bbfeead 100644 --- a/apps/server/src/api/v2/metric_files/[id]/GET.ts +++ b/apps/server/src/api/v2/metric_files/[id]/GET.ts @@ -60,7 +60,7 @@ async function getMetricHandler( // Use shared helper to fetch and process metric data const processedData = await fetchAndProcessMetricData(metricId, user, { - publicAccessPreviouslyVerfified: false, + publicAccessPreviouslyVerified: false, password, versionNumber, }); diff --git a/apps/server/src/shared-helpers/metric-helpers.ts b/apps/server/src/shared-helpers/metric-helpers.ts index 32de3feb3..0c7931725 100644 --- a/apps/server/src/shared-helpers/metric-helpers.ts +++ b/apps/server/src/shared-helpers/metric-helpers.ts @@ -15,18 +15,14 @@ import { type GetMetricResponse, type MetricYml, } from '@buster/server-shared/metrics'; -import { - type AssetPermissionRole, - AssetPermissionRoleSchema, - type VerificationStatus, -} from '@buster/server-shared/share'; +import type { AssetPermissionRole, VerificationStatus } from '@buster/server-shared/share'; import { HTTPException } from 'hono/http-exception'; import yaml from 'js-yaml'; import { z } from 'zod'; export const MetricAccessOptionsSchema = z.object({ /** If public access has been verified by a parent resource set to true */ - publicAccessPreviouslyVerfified: z.boolean().default(false), + publicAccessPreviouslyVerified: z.boolean().default(false), /** Password for public access validation */ password: z.string().optional(), /** Version number to fetch */ @@ -57,7 +53,7 @@ export async function fetchAndProcessMetricData( user: User, options: MetricAccessOptions ): Promise { - const { publicAccessPreviouslyVerfified = false, password, versionNumber } = options; + const { publicAccessPreviouslyVerified = false, password, versionNumber } = options; // Fetch metric details const metricFile = await getMetricFileById(metricId); @@ -69,7 +65,7 @@ export async function fetchAndProcessMetricData( }); } - let effectiveRole: AssetPermissionRole | undefined = publicAccessPreviouslyVerfified + let effectiveRole: AssetPermissionRole | undefined = publicAccessPreviouslyVerified ? 'can_view' : undefined;