Ling0925
/
buster
mirror of https://github.com/buster-so/buster.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fixed flawed metric screenshot logic

This commit is contained in:
Nate Kelley 2025-10-08 17:30:49 -06:00
parent 06cb498a46
commit cc9e269969
No known key found for this signature in database
GPG Key ID: FD90372AB8D98B4F
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/server/src/api/v2/chats/index.test.ts
View File

@ -83,6 +83,7 @@ describe('POST /chats', () => {
workspace_sharing: 'full_access', workspace_sharing: 'full_access',
workspace_member_count: 0, workspace_member_count: 0,
individual_permissions: [], individual_permissions: [],
screenshot_taken_at: null,
}; };
beforeEach(() => { beforeEach(() => {

6
apps/trigger/src/tasks/screenshots/take-metric-screenshot-handler.ts
View File

@ -64,12 +64,12 @@ const shouldTakenNewScreenshot = async ({
return true; return true;
} }
const isScreenshotExpired = await hasMetricScreenshotBeenTakenWithin( const hasRecentScreenshot = await hasMetricScreenshotBeenTakenWithin(
metricId, metricId,
dayjs().subtract(6, 'hours') dayjs().subtract(6, 'hours')
); );
logger.info('Is screenshot expired', { isScreenshotExpired }); logger.info('Has recent screenshot', { hasRecentScreenshot });
return isScreenshotExpired; return !hasRecentScreenshot;
}; };

4
packages/server-shared/src/chats/chat.types.test.ts
View File

@ -137,6 +137,7 @@ describe('ChatWithMessagesSchema', () => {
permission: 'owner', permission: 'owner',
workspace_sharing: 'full_access', workspace_sharing: 'full_access',
workspace_member_count: 0, workspace_member_count: 0,
screenshot_taken_at: '2024-01-01T00:00:00Z',
}; };
const result = ChatWithMessagesSchema.safeParse(validChat); const result = ChatWithMessagesSchema.safeParse(validChat);
@ -172,6 +173,7 @@ describe('ChatWithMessagesSchema', () => {
public_enabled_by: null, public_enabled_by: null,
public_password: null, public_password: null,
permission: 'owner', permission: 'owner',
screenshot_taken_at: null,
// Optional fields omitted // Optional fields omitted
}; };
@ -210,6 +212,7 @@ describe('ChatWithMessagesSchema', () => {
permission: 'owner', permission: 'owner',
workspace_sharing: 'full_access', workspace_sharing: 'full_access',
workspace_member_count: 0, workspace_member_count: 0,
screenshot_taken_at: null,
}; };
const result = ChatWithMessagesSchema.safeParse(chatWithInvalidPermissions); const result = ChatWithMessagesSchema.safeParse(chatWithInvalidPermissions);
@ -238,6 +241,7 @@ describe('ChatWithMessagesSchema', () => {
workspace_sharing: 'full_access', workspace_sharing: 'full_access',
workspace_member_count: 0, workspace_member_count: 0,
individual_permissions: [], individual_permissions: [],
screenshot_taken_at: null,
}; };
const result = ChatWithMessagesSchema.safeParse(chatWithValidDate); const result = ChatWithMessagesSchema.safeParse(chatWithValidDate);