From e1344fcfa609aa4cc12820f83e1efa9ce244a626 Mon Sep 17 00:00:00 2001
From: Nate Kelley <nate@buster.so>
Date: Mon, 14 Apr 2025 13:06:39 -0600
Subject: [PATCH] =?UTF-8?q?ready=20only=20in=20datasets=20=F0=9F=8E=89?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../DatasetIndividualThreeDotMenu.tsx         |  4 +-
 .../[datasetId]/editor/EditorContent.tsx      |  3 +-
 .../[datasetId]/editor/MetadataContainer.tsx  |  9 ++--
 .../datasets/[datasetId]/page.tsx             | 19 +++-----
 .../AppVerticalCodeSplitter.tsx               |  3 ++
 .../AppVerticalCodeSplitter/SQLContainer.tsx  | 43 ++++++++++++-------
 6 files changed, 46 insertions(+), 35 deletions(-)

diff --git a/web/src/app/app/(primary_layout)/datasets/[datasetId]/_DatasetsLayout/DatasetsIndividualHeader/DatasetIndividualThreeDotMenu.tsx b/web/src/app/app/(primary_layout)/datasets/[datasetId]/_DatasetsLayout/DatasetsIndividualHeader/DatasetIndividualThreeDotMenu.tsx
index 291bc8fc6..33cf4efeb 100644
--- a/web/src/app/app/(primary_layout)/datasets/[datasetId]/_DatasetsLayout/DatasetsIndividualHeader/DatasetIndividualThreeDotMenu.tsx
+++ b/web/src/app/app/(primary_layout)/datasets/[datasetId]/_DatasetsLayout/DatasetsIndividualHeader/DatasetIndividualThreeDotMenu.tsx
@@ -4,7 +4,7 @@ import { BusterRoutes } from '@/routes';
 import { Dropdown, DropdownItems } from '@/components/ui/dropdown';
 import { Button } from '@/components/ui/buttons';
 import React, { useMemo } from 'react';
-import { Dots, DotsVertical, Trash } from '@/components/ui/icons';
+import { Dots, Trash } from '@/components/ui/icons';
 
 export const DatasetIndividualThreeDotMenu: React.FC<{
   datasetId?: string;
@@ -31,7 +31,7 @@ export const DatasetIndividualThreeDotMenu: React.FC<{
   }, [datasetId, onDeleteDataset]);
 
   return (
-    <Dropdown items={items} side={'bottom'}>
+    <Dropdown items={items} side={'bottom'} align={'end'}>
       <Button variant={'ghost'} prefix={<Dots />} />
     </Dropdown>
   );
diff --git a/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/EditorContent.tsx b/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/EditorContent.tsx
index 5f1dbb56c..c0fc28cdb 100644
--- a/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/EditorContent.tsx
+++ b/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/EditorContent.tsx
@@ -76,11 +76,12 @@ export const EditorContent: React.FC<{
             data={shownData}
             fetchingData={fetchingInitialData || fetchingTempData}
             defaultLayout={defaultLayout}
+            readOnly={true}
           />
         )}
 
         {selectedApp === EditorApps.METADATA && (
-          <MetadataContainer ymlFile={ymlFile} setYmlFile={setYmlFile} />
+          <MetadataContainer ymlFile={ymlFile} setYmlFile={setYmlFile} readOnly={true} />
         )}
       </div>
     </div>
diff --git a/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/MetadataContainer.tsx b/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/MetadataContainer.tsx
index 5c3fa28a0..78f98b9d7 100644
--- a/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/MetadataContainer.tsx
+++ b/web/src/app/app/(primary_layout)/datasets/[datasetId]/editor/MetadataContainer.tsx
@@ -4,16 +4,17 @@ import React from 'react';
 
 export const MetadataContainer: React.FC<{
   ymlFile: string;
+  readOnly?: boolean;
   setYmlFile: (ymlFile: string) => void;
-}> = React.memo(({ ymlFile, setYmlFile }) => {
+}> = React.memo(({ ymlFile, setYmlFile, readOnly = false }) => {
   return (
-    <div
-      className={cn('bg-background rounded border', 'flex h-full w-full flex-col overflow-hidden')}>
+    <div className={cn('bg-background flex h-full w-full flex-col overflow-hidden rounded border')}>
       <AppCodeEditor
         language="yaml"
-        className="overflow-hidden"
+        className="border-none"
         value={ymlFile}
         onChange={setYmlFile}
+        readOnly={readOnly}
       />
     </div>
   );
diff --git a/web/src/app/app/(primary_layout)/datasets/[datasetId]/page.tsx b/web/src/app/app/(primary_layout)/datasets/[datasetId]/page.tsx
index 301bd9fcd..2353e74e6 100644
--- a/web/src/app/app/(primary_layout)/datasets/[datasetId]/page.tsx
+++ b/web/src/app/app/(primary_layout)/datasets/[datasetId]/page.tsx
@@ -1,25 +1,18 @@
 'use client';
-import React, { use } from 'react';
-import { permanentRedirect, RedirectType } from 'next/navigation';
+import React from 'react';
+import { permanentRedirect } from 'next/navigation';
 import { BusterRoutes, createBusterRoute } from '@/routes';
 
-export default function DashboardPage(
-  props: {
-    params: Promise<{ datasetId: string }>;
-  }
-) {
-  const params = use(props.params);
+export default async function DashboardPage(props: { params: Promise<{ datasetId: string }> }) {
+  const params = await props.params;
 
-  const {
-    datasetId
-  } = params;
+  const { datasetId } = params;
 
   permanentRedirect(
     createBusterRoute({
       route: BusterRoutes.APP_DATASETS_ID_OVERVIEW,
       datasetId
-    }),
-    RedirectType.replace
+    })
   );
 
   return <></>;
diff --git a/web/src/components/features/layouts/AppVerticalCodeSplitter/AppVerticalCodeSplitter.tsx b/web/src/components/features/layouts/AppVerticalCodeSplitter/AppVerticalCodeSplitter.tsx
index cfc54048a..cfd5d99b7 100644
--- a/web/src/components/features/layouts/AppVerticalCodeSplitter/AppVerticalCodeSplitter.tsx
+++ b/web/src/components/features/layouts/AppVerticalCodeSplitter/AppVerticalCodeSplitter.tsx
@@ -18,6 +18,7 @@ export interface AppVerticalCodeSplitterProps {
   disabledSave?: boolean;
   gapAmount?: number;
   className?: string;
+  readOnly?: boolean;
 }
 
 export const AppVerticalCodeSplitter = forwardRef<AppSplitterRef, AppVerticalCodeSplitterProps>(
@@ -29,6 +30,7 @@ export const AppVerticalCodeSplitter = forwardRef<AppSplitterRef, AppVerticalCod
       onRunQuery,
       onSaveSQL,
       data,
+      readOnly = false,
       fetchingData,
       defaultLayout,
       autoSaveId,
@@ -55,6 +57,7 @@ export const AppVerticalCodeSplitter = forwardRef<AppSplitterRef, AppVerticalCod
             onRunQuery={onRunQuery}
             onSaveSQL={onSaveSQL}
             disabledSave={disabledSave}
+            readOnly={readOnly}
           />
         }
         rightChildren={
diff --git a/web/src/components/features/layouts/AppVerticalCodeSplitter/SQLContainer.tsx b/web/src/components/features/layouts/AppVerticalCodeSplitter/SQLContainer.tsx
index 6212567da..34376e6e8 100644
--- a/web/src/components/features/layouts/AppVerticalCodeSplitter/SQLContainer.tsx
+++ b/web/src/components/features/layouts/AppVerticalCodeSplitter/SQLContainer.tsx
@@ -18,8 +18,18 @@ export const SQLContainer: React.FC<{
   onSaveSQL: AppVerticalCodeSplitterProps['onSaveSQL'];
   disabledSave?: AppVerticalCodeSplitterProps['disabledSave'];
   error?: string | null;
+  readOnly?: boolean;
 }> = React.memo(
-  ({ disabledSave, className = '', sql, setDatasetSQL, onRunQuery, onSaveSQL, error }) => {
+  ({
+    disabledSave,
+    className = '',
+    readOnly = false,
+    sql,
+    setDatasetSQL,
+    onRunQuery,
+    onSaveSQL,
+    error
+  }) => {
     const [isRunning, setIsRunning] = useState(false);
     const [isSaving, setIsSaving] = useState(false);
     const { openInfoMessage } = useBusterNotifications();
@@ -57,20 +67,22 @@ export const SQLContainer: React.FC<{
               </Button>
             )}
 
-            <Button
-              variant="default"
-              loading={isRunning}
-              disabled={!sql}
-              className="flex items-center space-x-0"
-              onClick={onRunQueryPreflight}
-              suffix={
-                <div className="flex items-center gap-x-1 text-sm">
-                  <Command />
-                  <ReturnKey />
-                </div>
-              }>
-              Run
-            </Button>
+            {!readOnly && (
+              <Button
+                variant="default"
+                loading={isRunning}
+                disabled={!sql}
+                className="flex items-center space-x-0"
+                onClick={onRunQueryPreflight}
+                suffix={
+                  <div className="flex items-center gap-x-1 text-sm">
+                    <Command />
+                    <ReturnKey />
+                  </div>
+                }>
+                Run
+              </Button>
+            )}
           </div>
         </>
       );
@@ -87,6 +99,7 @@ export const SQLContainer: React.FC<{
           onChange={setDatasetSQL}
           onMetaEnter={onRunQueryPreflight}
           variant={null}
+          readOnly={readOnly}
         />
 
         {error && <ErrorClosableContainer error={error} />}